Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in ElectronSeedProducer #9455

Merged
merged 1 commit into from Jun 5, 2015

Conversation

mark-grimes
Copy link

This fixes the crash in SLHC26 Phase1 2017 workflows reported here:

https://hypernews.cern.ch/HyperNews/CMS/get/relval/3696.html

Tested on 1 of the input sets specified in the tarballs discussed in that email. Logs from 12 of the 14 tarballs have the same error, the other 2 appear to complete successfully.
There are still the various warnings about missing input as pointed out here:

https://hypernews.cern.ch/HyperNews/CMS/get/upgrade-tp-studies/189.html

but the full sample now runs. Those errors are being investigated by experts, they will be fixed in another pull request as required.

@boudoul

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Fix crash in ElectronSeedProducer

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

@mark-grimes
Copy link
Author

merge

cmsbuild added a commit that referenced this pull request Jun 5, 2015
@cmsbuild cmsbuild merged commit 44e4bc5 into cms-sw:CMSSW_6_2_X_SLHC Jun 5, 2015
@mark-grimes mark-grimes deleted the fixTowerIsolation branch June 5, 2015 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants