Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPix Occupancy #9463

Merged
merged 2 commits into from
Jun 12, 2015
Merged

FPix Occupancy #9463

merged 2 commits into from
Jun 12, 2015

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Jun 4, 2015

Restore FPix cluster occupancy plots

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2015

A new Pull Request was created by @fioriNTU for CMSSW_7_5_X.

FPix Occupancy

It involves the following packages:

DQM/SiPixelMonitorCluster
DQM/SiStripMonitorClient

@cmsbuild, @danduggan, @deguio can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 5, 2015

please test

@deguio
Copy link
Contributor

deguio commented Jun 5, 2015

@fioriNTU
please clarify why two similar PR have been submitted. this one and #9463
thanks,
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

The tests are being triggered in jenkins.

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Jun 5, 2015

I have to say I am not very expert in git, what I did is to submit 2 PR,
in 7_4_X and 7_5_X with the same fix, and the same branch name, the
original branch name was FPix2D for both. But once made the PR in 7_5_X,
the system seems not accepting the same PR with the same branch name in
7_4_X, so I switched to a new branch and made the PR again ... I guess
this created the issue.
Hope this can help, let me know if you need more infos.

FF

Il 05/06/2015 11.56, deguio ha scritto:

@fioriNTU https://github.com/fioriNTU
please clarify why two similar PR have been submitted. this one and
#9463 #9463
thanks,
F.


Reply to this email directly or view it on GitHub
#9463 (comment).


Questa e-mail è stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus

@deguio deguio mentioned this pull request Jun 5, 2015
@fioriNTU
Copy link
Contributor Author

fioriNTU commented Jun 5, 2015

I realized I have made the pull request, with different name for the same 7_5_X
I will submit a new one for 7_4_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2015

-1
Tested at: ffc084c
When I ran the RelVals I found an error in the following worklfows:
50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50+MINIAODMCUP1550.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9463/5321/summary.html

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants