Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against infinite loops in gen status flag code #9489

Merged
merged 1 commit into from
Jun 8, 2015

Conversation

bendavid
Copy link
Contributor

@bendavid bendavid commented Jun 7, 2015

Some generators (ie sherpa) produce circular mother-daughter links in the generator truth. This caused infinite loops when filling gen status flags. (at either gen-sim or digi-reco time).
Protections have been added for this now.

Because the protections require some dynamically allocated space to keep track of the particles, implementing this efficiently required transitioning from a namespace to a class for MCTruthHelper.

Verified that there are no changes in flags for pythia8 samples where circular relations were not present.

This is a generalized fix which supersedes the more specific protection in
#9272

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_5_X.

Protect against infinite loops in gen status flag code

It involves the following packages:

PhysicsTools/HepMCCandAlgos

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2015

@monttj
Copy link
Contributor

monttj commented Jun 8, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants