-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect against infinite loops in gen status flag code #9489
Conversation
…ite loops in gen status flag code
A new Pull Request was created by @bendavid (Josh Bendavid) for CMSSW_7_5_X. Protect against infinite loops in gen status flag code It involves the following packages: PhysicsTools/HepMCCandAlgos @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs unless changes (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
Protect against infinite loops in gen status flag code
Some generators (ie sherpa) produce circular mother-daughter links in the generator truth. This caused infinite loops when filling gen status flags. (at either gen-sim or digi-reco time).
Protections have been added for this now.
Because the protections require some dynamically allocated space to keep track of the particles, implementing this efficiently required transitioning from a namespace to a class for MCTruthHelper.
Verified that there are no changes in flags for pythia8 samples where circular relations were not present.
This is a generalized fix which supersedes the more specific protection in
#9272