Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More All-In-One tool improvements #9532

Merged
merged 12 commits into from
Jul 19, 2015

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jun 9, 2015

The primary addition here is "preexisting" validations, which make it possible to configure the All In One tool to include validations that were already run into plots, without running them again.

This PR is independent of the upgrade to 75X (it's mostly in the python scripts) and all of the fixes that need to go with validations using data in the most recent releases. I hope that this will be merged relatively soon so that this PR and fixes for 75X data don't interfere with each other.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2015

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_5_X.

More All-In-One tool improvements

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 10, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@mmusich
Copy link
Contributor

mmusich commented Jun 10, 2015

@hroskes once merged do you plan it for 7.4.X too?

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jul 19, 2015
@cmsbuild cmsbuild merged commit 3cdb46c into cms-sw:CMSSW_7_5_X Jul 19, 2015
cmsbuild added a commit that referenced this pull request Jul 19, 2015
Backport of #9532: More All-In-One tool improvements
@hroskes hroskes deleted the improve-allinone-tool-75X branch July 19, 2015 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants