Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline validation for 74X collisions and cosmics #9635

Merged
merged 4 commits into from Jun 19, 2015

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Jun 16, 2015

Redo of #9551

CondDBv2 and ROOT6 compilation. Also in 75X as #9552, without the CondDBv2 part because as I understand it CondDBv2 is the default in 75X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_7_4_X.

Offline validation for 74X collisions and cosmics

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @frmeier, @mmusich, @tlampen this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Jun 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Jun 17, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jun 19, 2015
Offline validation for 74X collisions and cosmics
@cmsbuild cmsbuild merged commit d8d22c4 into cms-sw:CMSSW_7_4_X Jun 19, 2015
@hroskes hroskes deleted the for-first-collisions-test-744-PR branch June 19, 2015 10:02
@hroskes hroskes restored the for-first-collisions-test-744-PR branch June 21, 2015 20:20
@hroskes hroskes deleted the for-first-collisions-test-744-PR branch June 30, 2015 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants