-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults #9852
BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults #9852
Conversation
… Minuit changed them after V5.32)
…etter readability)
A new Pull Request was created by @menasce for CMSSW_7_5_X. BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults It involves the following packages: RecoVertex/BeamSpotProducer @diguida, @cvuosalo, @cerminar, @cmsbuild, @slava77, @mmusich can you please review it and eventually sign? Thanks. |
please test |
@menasce please open a corresponding one in 76X. |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
…M_Fix BeamSpot Fitter: added parameters to the migrad functor to supersede EDM defaults
Minuit changed the EDM (Estimated Distance to Minimum) default values after ROOT V5.35.
In order to reach the same convergence as with the old Minuit, we had to set the same default value: this has been accomplished using a polymorphic functor of migrad which accepts user-defined values.
This was a suggestion of Lorenzo Moneta, who helped us identify the problem of different convergence between old and new Minuit versions.
This fixed the problem: fits are now identical (within a factor of 10^-6)