Capabilities libraries are obsolete #9872
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_7_6_X. Capabilities libraries are obsolete It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. |
|
please test |
| @@ -272,7 +271,7 @@ namespace edm { | |||
|
|
|||
| // Load the library containing dictionaries for std:: classes, if not already loaded. | |||
| if (!hasDictionary(typeid(std::vector<std::vector<unsigned int> >))) { | |||
| edmplugin::PluginCapabilities::get()->load(dictionaryPlugInPrefix() + "std::vector<std::vector<unsigned int> >"); | |||
| TypeWithDict::byName("std::vector<std::vector<unsigned int> >"); | |||
There was a problem hiding this comment.
Do we even need this anymore?
There was a problem hiding this comment.
I'm not sure. What it does do is load libDataFormatsStdDectionaries.so if it is not already loaded. If you want, I can remove this in another PR and see if anything breaks
I can't remember if we need that library loaded up front.
There was a problem hiding this comment.
Definitely test in another PR
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
comparison-pending
and removed
comparison-pending
core-approved
fully-signed
orp-pending
tests-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
Capabilities libraries are obsolete
This pull request makes the necessary changes to the framework due to the fact that capabilities libraries are obsolete.
This PR includes the changes that are in #9857 (dependency), so there is no need to merge that PR also, although it should be harmless to do so.