Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes online applications. same as #9623 #9924

Merged
merged 1 commit into from
Jun 30, 2015

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Jun 26, 2015

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_5_X.

minor fixes online applications. same as #9623

It involves the following packages:

DQM/DTMonitorModule
DQM/Integration
RecoTauTag/Configuration

@cmsbuild, @cvuosalo, @danduggan, @deguio, @slava77 can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@@ -7,7 +7,7 @@
toGet = cms.VPSet(),
# connect = cms.string("frontier://FrontierPrep/CMS_COND_PHYSICSTOOLS") # prep database
connect = cms.string('frontier://FrontierProd/CMS_COND_PAT_000') # prod database
#'sqlite_file:/afs/cern.ch/user/j/jez/public/tauID/RecoTauTag_MVAs_2014Oct22.db')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did these commented out lines have to be modified?
If not, I suggest not to so that the reco signature is not needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ciao @Slava,
this is just to simplify our life since we have to patch manually the module to be able to run the reco step at p5.
thanks for signing.
ciao,
F.

@slava77
Copy link
Contributor

slava77 commented Jun 26, 2015

+1

for #9924 de30fe0

  • reco code is touched only in commented out lines (not obviously why)

@slava77
Copy link
Contributor

slava77 commented Jun 26, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@deguio
Copy link
Contributor Author

deguio commented Jun 29, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants