Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT migration to stage-2 L1T #3

Closed
Martin-Grunewald opened this issue Feb 19, 2016 · 9 comments
Closed

HLT migration to stage-2 L1T #3

Martin-Grunewald opened this issue Feb 19, 2016 · 9 comments

Comments

@Martin-Grunewald
Copy link

Need replacement for summary report module L1GtTrigReport - the module L1TGlobalAnalyzer does not apply to do what I need: and end-of-run/job summary report a la L1GtTrigReport.
One line per algo with event counts for accept/reject, and possibly also before/after prescale, before/after mask.

@Martin-Grunewald
Copy link
Author

Need more PRs beyond 800:
cms-sw#13257
cms-sw#13316
cms-sw#13340 # now in 80X IB
Need to make another PR collecting the HLT code changes.

@Martin-Grunewald
Copy link
Author

L1T menus need fixing AND need to go into the release (as long as we need xml for lack of o2o).
But David Lange is blocking this, eg, here: cms-sw#13316

@Martin-Grunewald
Copy link
Author

According to ConfDB, the master table now only contains the remaining following references to the
hltL1extraParticles collections: instances of these plugins:

HLTEgammaL1MatchFilterRegional
HLTEcalRecHitInAllL1RegionsProducer
EgammaHLTCaloTowerProducer

HLTMuonL1Filter
HLTL1MuonSelector
L2MuonSeedGenerator

CaloTowerCreatorForTauHLT

HLTPFJetL1MatchProducer

IsolatedPixelTrackCandidateProducer

Of course, this is HLT only! Reco and DQM contain many more plugins.

Further modules under HLTrigger:

HLTEgammaL1MatchFilterPairs
PFJetsMatchedToFilteredCaloJetsProducer
HLTJetL1MatchProducer
HLTSinglet
HLTMuonL1RegionalFilter
HLTMuonL1toL3TkPreFilter
HLTMuonL2ToL1Map
HLTMuonTrkFilter
HLTPixelIsolTrackFilter

(rekovic added a migrated HLTMuonL1Filter plugin called HLTMuonL1TFilter...)

L1T Migration (non-l1extra) is also needed for these:

HLTPrescaler                          # done in my area
TriggerResultsFilter
TriggerResultsFilterFromDB

@fwyzard
Copy link

fwyzard commented Feb 19, 2016

Hi Martin,
I remember I found some more and listed them in the news some times ago... can you check against that list as well ?
Maybe there are modules which make use of the hltGtDigis, in addition to the "extra particles" ?
Those would need to be migrated to the new L1 collections as well.

@Martin-Grunewald
Copy link
Author

@fwyzard
I could only find your email:

Date: Wed, 20 Jan 2016 01:43:06
From: Andrea Bocci <fwyzard@gmail.com>
To: Vladimir Rekovic <Vladimir.Rekovic@cern.ch>,
    Michael Mulhearn <mulhearn@physics.ucdavis.edu>,
    Michael Mulhearn <michaeljmulhearn@gmail.com>,
    Martin Grunewald <Martin.Grunewald@cern.ch>,
    Andrea Perrotta <andrea.perrotta@bo.infn.it>
Subject: Talk on L1 Offline Software this Thursday

which is also put here: cms-l1t-offline#103 (comment)

The modules listed there are covered above!

@Martin-Grunewald
Copy link
Author

@fwyzard
Could you please take care of the TriggerResultsFilter[FromDB]?

@fwyzard
Copy link

fwyzard commented Feb 19, 2016 via email

@Martin-Grunewald
Copy link
Author

Migration to stage-2 L1T - still to do:

  • TriggerResultsFilter[FromDB]
  • HLTLevel1ActivityFilter
  • TriggerSummaryAnalyzer AOD and RAW
  • HLTEventAnalyzer AOD and RAW (needs L1GtUtils replacement from L1T)
  • HLTPrescaleProvider (needs L1GtUtils replacement from L1T)

@Martin-Grunewald
Copy link
Author

Close as resolved

Martin-Grunewald pushed a commit that referenced this issue Jul 6, 2017
Fetching L1TMuonEndCapParams from the EventSetup #3
Martin-Grunewald pushed a commit that referenced this issue Jul 20, 2017
Martin-Grunewald pushed a commit that referenced this issue Jul 20, 2017
Martin-Grunewald pushed a commit that referenced this issue Aug 15, 2018
Martin-Grunewald pushed a commit that referenced this issue Nov 15, 2018
Martin-Grunewald pushed a commit that referenced this issue Dec 2, 2018
Use cloning in modules, Add back DeepDoubleBTagInfo.h in the meantime so PR can be tested
Martin-Grunewald pushed a commit that referenced this issue Jun 10, 2019
Martin-Grunewald pushed a commit that referenced this issue Jun 24, 2019
Improved CellGrid implementation.
Martin-Grunewald pushed a commit that referenced this issue Mar 31, 2020
Martin-Grunewald pushed a commit that referenced this issue Nov 23, 2020
Martin-Grunewald pushed a commit that referenced this issue Dec 7, 2020
Fixing I/O rules for ScoutingMuon backward accessibility
Martin-Grunewald pushed a commit that referenced this issue Feb 1, 2021
Martin-Grunewald pushed a commit that referenced this issue Mar 12, 2021
Martin-Grunewald pushed a commit that referenced this issue Jul 13, 2021
pull from cmssw/master
Martin-Grunewald pushed a commit that referenced this issue Oct 13, 2021
Martin-Grunewald pushed a commit that referenced this issue Feb 7, 2022
missirol pushed a commit that referenced this issue Jun 6, 2022
missirol pushed a commit that referenced this issue May 4, 2023
Recover fillDescriptions as requested
missirol pushed a commit that referenced this issue May 21, 2023
missirol pushed a commit that referenced this issue Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants