Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

atom pollution #13

Closed
jclopes opened this issue Sep 30, 2010 · 2 comments
Closed

atom pollution #13

jclopes opened this issue Sep 30, 2010 · 2 comments

Comments

@jclopes
Copy link

jclopes commented Sep 30, 2010

I noticed that ibrowse was polluting the virtualmachine with atoms when passed bogus URLs.
The functions ibrowse_lib:parse_url calls list_to_atom to get the URL protocol but if it's not a well formed URL it will pollute the node with useless atoms.

I see 2 possible solutions:

  1. keep the protocol as a string
  2. check if it's a supported protocol before the list_to_atom call ["http", "https"]
@cmullaparthi
Copy link
Owner

I suppose I could use list_to_existing_atom, but that is probably only supported in newer versions of Erlang/OTP. Thanks for the bug report. I'll try and come up with a solution.

@cmullaparthi
Copy link
Owner

Ok, I've decided that list_to_existing_atom is a safe thing to do. This will be part of the next release of ibrowse.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cmullaparthi @jclopes