fix: try to link latest version to top node_modules (#284)

revert https://github.com/cnpm/npminstall/pull/282/files#diff-fcb03c95bc3ad63da4b4490a731316fbR150 changed
cnpm · Dec 11, 2018 · 20bbb17 · 20bbb17
1 parent e7f1f05
commit 20bbb17
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/lib/local_install.js b/lib/local_install.js
@@ -147,12 +147,10 @@ function* _install(options) {
   options.spinner && options.spinner.succeed(`Installed ${tasks.length} packages`);
 
   if (!options.disableDedupe) {
-    // don't link latest versions on `npminstall pkgName` way
-    if (options.pkgs.length === 0) {
-      // dedupe mode https://docs.npmjs.com/cli/dedupe
-      // link every packages' latest version to target directory
-      yield linkAllLatestVersion(rootPkgsMap, options);
-    }
+    // dedupe mode https://docs.npmjs.com/cli/dedupe
+    // link every packages' latest version to target directory
+    // won't override exists target directory
+    yield linkAllLatestVersion(rootPkgsMap, options);
   } else {
     options.spinner && options.spinner.succeed('disable dedupe mode');
   }

diff --git a/test/local-install-pkgs.test.js b/test/local-install-pkgs.test.js
@@ -25,7 +25,8 @@ describe('test/local-install-pkgs.test.js', () => {
       .end();
     const names = fs.readdirSync(path.join(root, 'node_modules'))
       .filter(n => !/^[\.\_]/.test(n));
-    assert(names.length === 1);
-    assert(names[0] === 'koa');
+    assert(names.length > 10);
+    assert(names.indexOf('koa') > 0);
+    assert(names.indexOf('accepts') >= 0);
   });
 });