fix: cnpm install error without user settings (#301)

cnpm · May 8, 2019 · 2688fa8 · 2688fa8
1 parent ef1432a
commit 2688fa8
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 2 deletions.
diff --git a/lib/get.js b/lib/get.js
@@ -46,8 +46,9 @@ function* get(url, options, globalOptions) {
   // need auth
   const registryUrl = cnpmConfig.get('registry');
   const registryUri = registryUrl && registryUrl.replace(urlParser.parse(registryUrl).protocol, '') || '';
-  const authed = registryUri && url.indexOf(registryUri) !== -1 || false;
-  if (authed || cnpmConfig.get(registryUri + ':always-auth') || cnpmConfig.get('always-auth')) {
+  const authed = registryUri && url.indexOf(registryUri) !== -1;
+  const hasUserSettings = typeof cnpmConfig.get(registryUri + ':username') === 'string' && typeof cnpmConfig.get(registryUri + ':_password') ===  'string';
+  if (hasUserSettings && (authed || cnpmConfig.get(registryUri + ':always-auth') || cnpmConfig.get('always-auth'))) {
     const authToken = (`${cnpmConfig.get(registryUri + ':username')}:${Buffer.from(cnpmConfig.get(registryUri + ':_password'), 'base64').toString()}`);
     options.headers.Authorization = `Basic ${Buffer.from(authToken).toString('base64')}`;
   }

diff --git a/test/fixtures/initial-cnpmrc/.cnpmrc b/test/fixtures/initial-cnpmrc/.cnpmrc
@@ -0,0 +1 @@
+registry=https://registry.npmjs.com/
diff --git a/test/install-without-userconfig.test.js b/test/install-without-userconfig.test.js
@@ -0,0 +1,30 @@
+'use strict';
+
+const path = require('path');
+const rimraf = require('rimraf');
+const coffee = require('coffee');
+const npminstall = path.join(__dirname, '..', 'bin', 'install.js');
+
+const cwd = path.join(__dirname, './fixtures/initial-cnpmrc/');
+
+describe('test/install-without-userconfig.test.js', () => {
+  it('should run cnpm install successfully without cnpmrc userconfig', function* () {
+    function cleanup() {
+      rimraf.sync(path.join(cwd, 'node_modules'));
+    }
+
+    beforeEach(cleanup);
+    afterEach(cleanup);
+
+    yield coffee.fork(npminstall, ['webpack-parallel-uglify-plugin@1.0.0'], { 
+        cwd: cwd, 
+        env: Object.assign({}, process.env, { 
+          USERPROFILE: cwd, 
+          HOME: cwd 
+        }) 
+      })
+      .debug()
+      .expect('code', 0)
+      .end();
+  });
+});