Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always _discover_all when finding a sub-handle #3757

Open
ktbarrett opened this issue Mar 5, 2024 · 1 comment
Open

Always _discover_all when finding a sub-handle #3757

ktbarrett opened this issue Mar 5, 2024 · 1 comment
Labels
category:codebase:handle relating to handles or handle types (BinaryValue)

Comments

@ktbarrett
Copy link
Member

Currently we opportunistically attempt to find a handle by name without first discovering sub-handles. This often does not work. We could instead add some logic such that if it fails, it _discover_alls and then tries again before failing.

@ktbarrett ktbarrett added the category:codebase:handle relating to handles or handle types (BinaryValue) label Mar 5, 2024
@marlonjames
Copy link
Contributor

#2079 added this to try and help with pseudo-region discovery, since the VPI iteration code was better at finding those.
The followup #2143 which added iteration fallback in child handle lookup by name for Icarus took it out. And now #3817 expanded the VPI fallback to all simulators.

I'm not opposed to it in theory, I just wonder if there are any cases where iterating using the ordered set of iterators in the GPI implementations would give a handle to a different object than when looked up by name directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:codebase:handle relating to handles or handle types (BinaryValue)
Projects
None yet
Development

No branches or pull requests

2 participants