Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 160 hangouts endpoint first pass #193

Closed
wants to merge 32 commits into from
Closed

Issue 160 hangouts endpoint first pass #193

wants to merge 32 commits into from

Conversation

BethanyG
Copy link
Member

@BethanyG BethanyG commented Sep 26, 2020 •
edited

What type of PR is this? (check all applicable)

working branch: issue-160-hangouts-endpoint
Note: Because this code has been branched from the work in dj-rest-auth, the commits for PR #187 can also be seen in this PR.

  • 🐛 Bug Fix
  • ✨ Feature (e.g. API change, enhancement, addition, etc.)
  • ♻️ Refactor
  • 📝 Documentation
  • 🔖 Release
  • 🚩 Other (concerning: )

Context

"Rough Draft" of Hangouts endpoint. Includes app.py, models.py, and admin.py. See issue #160 for more detail and the inter-related issues for tracking. See FE discussions codebuddies/frontend#137 & codebuddies/frontend#139 for additional discussion.

Other Related Tickets & Documents

#161, #163, #164, #167

Implementation Details

What was your thought process as you changed the code? What does someone need to consider in reviewing it?

I left notes and questions under the related issues. Model and JSON are far from finalized. Additionally, this build has a somewhat "broken" admin interface -- inlines are not working there yet.

Added a hangouts app
Added hangout, hangoutresponses and hangoutsessions tables
Added a many-to-many for resources to hangout and to hangoutsessions
Added a many-to-many for users to hangout, hangoutsessions, and hangoutresponses
Started to add the endpoint to the admin, but encountered some issues.

New Libraries/Dependancies Introduced (Fill out as needed)

This requires a re-build and db migrations for the new tables.

Any new migration files added?

  • [ x] 👍 yes -- 0001_inital.py for initial hangouts tables creation.
  • 🙅 no, because they aren't needed

Did you add tests?

Code added or changed without test coverage or good reason for exemption won't be approved.

  • 👍 yes
  • 🙋 no, because I need help
  • 🙅 no, because they aren't needed - this is a WIP PR, and is not yet finalized to the point where test can be written

Did you add documentation?

  • 📜 readme.md
  • 📜 contributing.md
  • 📜 wiki entry
  • 🙋 I'd like someone to help write documentation, and will file a new issue for it
  • [ X] 🙅 no documentation needed -- again, this is a WIP and is not finalized yet.

@BethanyG
Added osprojects to admin interface.
dcbab36
@BethanyG
Added osprojects to admin interface.
31edf0f
@BethanyG
Added OSProjects to admin interface.
d585cdd
@BethanyG
added django-res-auth and associated basic settings to test DRF and a…
606c871 
…llauth together.
@BethanyG
Working state Mon Sept 14 - dj-rest-auth and django-allauth
30936fe
@BethanyG
Removed django-rest-jwt and django-rest-auth added simplejwt and dj-r…
cdadba1 
…est-auth settings.
@BethanyG
Added routes for registration and allauth.
782e05b
@BethanyG
Added password reset email template.
040c6f3
@BethanyG
Added confirm_email method. Will probably remove it as uneeded later.
ef3a5ad
@BethanyG
Added CustomUserDetailsSerializer. Stubbed other serializers for conf…
7e6ff72 
…rm emails and password reset.
@BethanyG
Added routes for registration, email confirmation, password reset, lo…
e97153b 
…gin, logout, and user details. Reorganized.
@BethanyG
Added CustomVerifyEmailView to enable email verify emails from the ba…
b6c4ac2 
…ckend.
@BethanyG
Added tests for registration flow, token authorization, email verific…
f06a74c 
…ation, etc.
@BethanyG
Fixed tests that were failing due to auth change.
221b7b6
@BethanyG
Added final simpleJWT tests for auth.
e8197e7
@BethanyG
Added skips for User tests broken due to auth changes.
f220224
@BethanyG
Removed django-rest_auth and django-rest-jwt from requirememts.
bb47eb0
@BethanyG
Removed unused import that was causing an error.
9fd6eb7
@BethanyG
Removed excess space from email_confirmation_subject.txt filename.
2670780
@BethanyG
Revert "Removed excess space from email_confirmation_subject.txt file…
9451986 
…name."

This reverts commit 2670780.

This file rename breaks allauth and all auth test cases for some reason.  It also causes a python failure due to an endless import recursion.
Not sure why/how this came about, but the easiest thing is to leave it as-is, and revert the change.
@BethanyG
Attempted to fix intermittent email verification post test failure by…
aa6218a 
… updating settings and tests.
@BethanyG
Changed order of included URLs.
f91a22d
@BethanyG
Added specific path for email link verification post and changed path…
a2b2b4b 
… regex.
@BethanyG
Fun trick: If your regex fails to capture all the key generations cas…
569ee99 
…es, it will fail intermittently - not consistantly.
@BethanyG
Removed print statement from email post verificaton test case.
35c5610
@BethanyG
Corrected circular reference that was breaking tests and renamed file…
75e9461 
… to exclude extra space.
@BethanyG
Removed regex from path url to avoid djang deprecation and migration …
b2ba2c2 
…warnings.
@BethanyG
New stub files after running create app script for django.
6934291
@BethanyG
Registered Hangouts as an app.
738f7c1
@BethanyG
WIP for registering Hangouts in admin. Issues with properly inlining …
11c40e2 
…model.
@BethanyG BethanyG removed the stale label Oct 27, 2020
@stale
Copy link

stale bot commented Nov 26, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 26, 2020
@BethanyG
Copy link
Member Author

Still open.

@stale stale bot removed the stale label Nov 26, 2020
@stale
Copy link

stale bot commented Jan 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 25, 2021
@BethanyG BethanyG removed the stale label Jan 25, 2021
@BethanyG
Copy link
Member Author

Keeping this open, as I hope to get to it soonish.

@stale
Copy link

stale bot commented Mar 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 26, 2021
@BethanyG
Copy link
Member Author

Still open.

@stale stale bot removed the stale label Mar 26, 2021
@stale
Copy link

stale bot commented May 27, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 27, 2021
@BethanyG BethanyG removed the stale label May 27, 2021
@stale
Copy link

stale bot commented Jul 26, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 26, 2021
@BethanyG BethanyG removed the stale label Jul 27, 2021
@stale
Copy link

stale bot commented Sep 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 25, 2021
@BethanyG BethanyG removed the stale label Sep 25, 2021
@BethanyG BethanyG closed this Oct 4, 2021
MVP progress tracker automation moved this from In progress to Done Oct 4, 2021
@BethanyG BethanyG reopened this Oct 4, 2021
MVP progress tracker automation moved this from Done to In progress Oct 4, 2021
@stale
Copy link

stale bot commented Dec 3, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 3, 2021
@stale stale bot closed this Dec 10, 2021
MVP progress tracker automation moved this from In progress to Done Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpatmo lpatmo Awaiting requested review from lpatmo

Assignees
No one assigned
Labels
stale
Projects
MVP progress tracker
  
Done
Milestone
No milestone
1 participant
@BethanyG