Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Registration] Verify Email Address Email Link Contains Incorrect URI #191

Open
BethanyG opened this issue Sep 24, 2020 · 4 comments
Open

Comments

@BethanyG
Copy link
Member

BethanyG commented Sep 24, 2020

Currently (as of PR #187 ) , when a user visits api/v1/auth/registraion/ and POSTs their details to register, a "verify your email address email" is sent containing a clickable URI that will send a user to a validate your email form. The dev URI is incorrect, and will need to point to whichever React component on the front end that is going to handle email address verification.

Current URI is:

http://localhost:8000/api/v1/auth/registration/verify-email/?key=<KEY>

but will need to be something pointing to the front end, but with the KEY in it. The front-end will then need to POST to api/v1/auth/registration/verify-email/ with the following:

{
    "key": <KEY>
}

Which will validate the email address (mark as verified in the DB) of whichever user is represented by the KEY.

The URI is handled in Django settings under config/settings/base.py. The URL can be changed with CUSTOM_ACCOUNT_CONFIRM_EMAIL_URL. Additionally, core/templates/account/email/email_confirmation_message.txt may need to change, but it will need to be tested to confrim.

@BethanyG BethanyG added bug Something isn't working good first issue Good for newcomers P1 for MVP labels Sep 24, 2020
@BethanyG BethanyG added this to To do in MVP progress tracker via automation Sep 24, 2020
@BethanyG BethanyG added this to Needs triage in All issues organized by priority via automation Sep 24, 2020
@BethanyG BethanyG changed the title [New User Registration] Verify Email Address Email Link Contains Incorrect URI [User Registration] Verify Email Address Email Link Contains Incorrect URI Sep 24, 2020
@stale
Copy link

stale bot commented Oct 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 24, 2020
@BethanyG BethanyG removed the stale label Oct 24, 2020
@stale
Copy link

stale bot commented Nov 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 23, 2020
@BethanyG
Copy link
Member Author

Still open.

@BethanyG BethanyG removed the stale label Nov 23, 2020
@stale
Copy link

stale bot commented Dec 23, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 23, 2020
@BethanyG BethanyG removed the stale label Dec 24, 2020
@lpatmo lpatmo added the pinned label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers P1 for MVP pinned
Development

No branches or pull requests

2 participants