Issue: intermittent problems signing in to codebuddies.org

[lpatmo]

Thanks to Annie and Bill for reporting.

Should look in console to see if there are any errors.

[lpatmo]

Windows 7 Chrome + Firefox issues reported by @h2c on Slack:

[lpatmo]

The error is happening on line 18 of .meteor/local/build/programs/web.browser/packages/oauth/end_of_popup_response.js, and this is line 18: if (window.opener && window.opener.Package &&

Full code:

  var config = JSON.parse(document.getElementById("config").innerHTML);

  if (config.setCredentialToken) {
    var credentialToken = config.credentialToken;
    var credentialSecret = config.credentialSecret;

    if (config.isCordova) {
      var credentialString = JSON.stringify({
        credentialToken: credentialToken,
        credentialSecret: credentialSecret
      });

      window.location.hash = credentialString;
    }

    if (window.opener && window.opener.Package &&
          window.opener.Package.oauth) {
      window.opener.Package.oauth.OAuth._handleCredentialSecret(
        credentialToken, credentialSecret);
    } else {
      try {
        localStorage[config.storagePrefix + credentialToken] = credentialSecret;
      } catch (err) {
        // We can't do much else, but at least close the popup instead
        // of having it hang around on a blank page.
      }
    }
  }

  if (! config.isCordova) {
    document.getElementById("completedText").style.display = "block";
    document.getElementById("loginCompleted").onclick = function(){ window.close(); };
    window.close();
  }
})();

[wuworkshop]

I initially thought this was a Windows-only error, but I just now had an issue logging in using Slack. I didn't get the first error message in h2c's screenshot. I did get the second error message:

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.

After a couple of tries, I was able to log in. This is on macOS High Sierra + Firefox 65.0

[lpatmo]

@wuworkshop Thank you! Maybe that other issue has higher weight too; will look into it. :)

[lpatmo]

@tgrrr also reports problems logging in from Chrome mobile.

[angelocordon]

Definitely something weird going on - I've signed on once, then refreshed about two or three times (without signing on again) and the session finally started.

[cbelsole]

I looked into this a little and was not able to recreate the login issue. I did experience the one @angelocordon referenced. My guess is that it is a server-side syncing issue. The client code looks good and once the server is "warm" the problem does not happen again.

[lpatmo]

Encountered by @cbelsole:

I have no idea what the string of characters at the top is (starting from data:application/jaascript;base64... but I would like to click on it if I ever encounter it and see where it's coming from (hangouts line 1??)

[angelocordon]

That's weird... kind of looks like an SVG data being set as a background property for an icon

[Lauro235]

Im having trouble signing in via git hub. I have an email co firming that code buddies has been allocated its github permissions, and I can click the link and see it. But if I click applications from git hub neither type of application shows codebuddies. When I log into codebuddies via github, I get redirected to codebuddies page without completing sign in.. Not sure if anyone has experienced this?

[lpatmo]

@Lauro235 Sorry for missing your message... wanted to note that we're looking into the GitHub issue on #1171. Sorry for the inconvenience!