Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: gallery-like behavior for video folder? #258

Open
knguyen0105 opened this issue Oct 8, 2019 · 2 comments
Open

feature request: gallery-like behavior for video folder? #258

knguyen0105 opened this issue Oct 8, 2019 · 2 comments

Comments

@knguyen0105
Copy link

Currently, if a folder has multiple videos I have to close a video before playing the next one. This takes 3 keystrokes: ESC, Up/Down, Enter

It would be nice if I can press '->' or '<-' to play / view the next/previous videos (or multimedia files). Similar to how cloudcmd handles images folder right now. This only takes one keystroke: Left / Right

Thanks.

@knguyen0105
Copy link
Author

@coderaiser : could you give me a few pointers where to start? I want to give this a try myself. Thanks.

@coderaiser
Copy link
Owner

coderaiser commented Oct 16, 2019

@knguyen0105 I think the best way to do this, is extending @cloudcmd/modal to support video as well.
@cloudcmd/modal is a simplified fancybox drop-in replacement.
It used to show modals in Cloud Commander with images, editors, configuration console and terminal.

This is how it works right now, it file client/modules/view.js there is a switch block with an image/media check.

viewMedia uses the same modal as view, but embeds template there.

To add video support to modal.js should be added isVideo check and would be great to add parse-media in similar way as parse-images.

The only one open question is: now left and right keys works as rewind. What do you think the best way of handling rewind? Is it useful feature?

I created an issue cloudcmd/modal#1.
if you get into trouble ask me any questions and I'll help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants