/
ColourSchemes.cpp
467 lines (364 loc) · 16.1 KB
/
ColourSchemes.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
#include "RadiantTest.h"
#include "icolourscheme.h"
#include "iregistry.h"
#include "math/Vector3.h"
#include "os/path.h"
#include "string/convert.h"
#include "xmlutil/Document.h"
namespace test
{
namespace
{
const char* const SCHEME_DARKRADIANT_DEFAULT = "DarkRadiant Default";
const char* const SCHEME_QE3 = "QE3Radiant Original";
const char* const SCHEME_BLACK_AND_GREEN = "Black & Green";
const char* const SCHEME_MAYA_MAX = "Maya/Max/Lightwave Emulation";
const char* const SCHEME_SUPER_MAL = "Super Mal";
}
class ColourSchemeTest :
public RadiantTest
{
protected:
void copySchemeFileToSettingsPath(const std::string& schemeFile)
{
fs::path schemeFilePath = _context.getTestResourcePath();
schemeFilePath /= "settings/";
schemeFilePath /= schemeFile;
fs::path targetFile = _context.getSettingsPath();
targetFile /= "colours.xml";
fs::remove(targetFile);
fs::copy(schemeFilePath, targetFile);
}
};
class ColourSchemeTestWithIncompleteScheme :
public ColourSchemeTest
{
public:
void SetUp() override
{
copySchemeFileToSettingsPath("colours_incomplete.xml");
RadiantTest::SetUp();
}
};
class ColourSchemeTestWithUserColours :
public ColourSchemeTest
{
protected:
fs::path _userDefinedSchemePath;
public:
void SetUp() override
{
// Store the value locally, the test case wants to have it
_userDefinedSchemePath = _context.getTestResourcePath();
_userDefinedSchemePath /= "settings/colours_userdefined.xml";
copySchemeFileToSettingsPath("colours_userdefined.xml");
RadiantTest::SetUp();
}
};
class ColourSchemeTestWithEmptySettings :
public ColourSchemeTest
{
public:
void SetUp() override
{
// Kill any colours.xml file present in the settings folder before regular SetUp
fs::path coloursFile = _context.getSettingsPath();
coloursFile /= "colours.xml";
fs::remove(coloursFile);
RadiantTest::SetUp();
}
};
namespace
{
std::map<std::string, Vector3> loadSchemeFromXml(const std::string& name, const std::string& xmlPath)
{
xml::Document doc(xmlPath);
auto schemes = doc.findXPath("//colourscheme[@name='" + name + "']");
EXPECT_EQ(schemes.size(), 1) << "Multiple schemes named " << name << " in file " << xmlPath;
auto schemeColours = doc.findXPath("//colourscheme[@name='" + name + "']//colour");
EXPECT_NE(schemeColours.size(), 0) << "Scheme " << name << " is empty";
std::map<std::string, Vector3> result;
for (auto colourNode : schemeColours)
{
result[colourNode.getAttributeValue("name")] = string::convert<Vector3>(colourNode.getAttributeValue("value"));
}
return result;
}
std::size_t getItemCountInScheme(const colours::IColourScheme& scheme)
{
std::size_t result = 0;
scheme.foreachColour([&](const std::string&, const colours::IColourItem& item) { ++result; });
return result;
}
}
// With an empty settings folder, the default schemes should be loaded
TEST_F(ColourSchemeTestWithEmptySettings, LoadDefaultSchemes)
{
auto defaultSchemeNames = {
SCHEME_DARKRADIANT_DEFAULT,
SCHEME_QE3,
SCHEME_BLACK_AND_GREEN,
SCHEME_MAYA_MAX,
SCHEME_SUPER_MAL
};
// Check the default colours.xml file
std::string defaultColoursFile = _context.getRuntimeDataPath() + "colours.xml";
EXPECT_TRUE(fs::exists(defaultColoursFile)) << "Could not find factory colours file: " << defaultColoursFile;
for (auto name : defaultSchemeNames)
{
EXPECT_TRUE(GlobalColourSchemeManager().schemeExists(name)) << "Scheme " << name << " not found";
auto defaultScheme = loadSchemeFromXml(name, defaultColoursFile);
auto& loadedScheme = GlobalColourSchemeManager().getColourScheme(name);
// Number of items must match
EXPECT_EQ(defaultScheme.size(), getItemCountInScheme(loadedScheme));
// Each item must match
for (const auto& defaultColour : defaultScheme)
{
EXPECT_EQ(loadedScheme.getColour(defaultColour.first).getColour(), defaultColour.second)
<< "Scheme " << name << ": colour " << defaultColour.first
<< " doesn't match the default value " << defaultColour.second;
}
}
}
TEST_F(ColourSchemeTestWithEmptySettings, DefaultSchemeIsActive)
{
EXPECT_EQ(GlobalColourSchemeManager().getActiveScheme().getName(), SCHEME_DARKRADIANT_DEFAULT);
}
TEST_F(ColourSchemeTestWithEmptySettings, ChangeActiveScheme)
{
auto newSchemeName = SCHEME_SUPER_MAL;
GlobalColourSchemeManager().setActive(newSchemeName);
EXPECT_EQ(GlobalColourSchemeManager().getActiveScheme().getName(), newSchemeName);
}
TEST_F(ColourSchemeTestWithEmptySettings, ActiveSchemePersisted)
{
// Check the current default
auto activeSchemes = GlobalRegistry().findXPath("user/ui/colourschemes//colourscheme[@active='1']");
EXPECT_EQ(activeSchemes.size(), 1);
EXPECT_EQ(activeSchemes[0].getAttributeValue("name"), SCHEME_DARKRADIANT_DEFAULT);
auto newSchemeName = SCHEME_SUPER_MAL;
GlobalColourSchemeManager().setActive(newSchemeName);
// Export the state to the registry
GlobalColourSchemeManager().saveColourSchemes();
// By this time, the colour scheme should be saved to the registry
// This is checking implementation details, but it might be worth it
activeSchemes = GlobalRegistry().findXPath("user/ui/colourschemes//colourscheme[@active='1']");
EXPECT_EQ(activeSchemes.size(), 1);
EXPECT_EQ(activeSchemes[0].getAttributeValue("name"), newSchemeName);
// Save to disk
GlobalRegistry().saveToDisk();
// Check the XML files if the active flag was set
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
xml::Document doc(savedColoursFile);
auto schemes = doc.findXPath("//colourscheme[@active='1']");
EXPECT_EQ(schemes.size(), 1) << "More than one scheme set to active in " << savedColoursFile;
EXPECT_EQ(schemes[0].getAttributeValue("name"), newSchemeName);
}
namespace
{
void modifySchemeColour(const std::string& schemeToModify, const std::string& colourName, const Vector3& newValue)
{
auto& scheme = GlobalColourSchemeManager().getColourScheme(schemeToModify);
EXPECT_NE(scheme.getColour(colourName).getColour(), newValue) << "Test setup failure: colour is already set to new RGB values";
// Modify one colour
scheme.getColour(colourName).getColour() = newValue;
}
}
TEST_F(ColourSchemeTestWithEmptySettings, SystemThemeColourChangePersisted)
{
Vector3 newValue(0.99, 0.99, 0.99);
modifySchemeColour(SCHEME_DARKRADIANT_DEFAULT, "default_brush", newValue);
// Export the state to the registry and save it to disk
GlobalColourSchemeManager().saveColourSchemes();
GlobalRegistry().saveToDisk();
// Check the XML files if the colour was set
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
auto savedScheme = loadSchemeFromXml(SCHEME_DARKRADIANT_DEFAULT, savedColoursFile);
EXPECT_EQ(savedScheme["default_brush"], newValue);
}
TEST_F(ColourSchemeTestWithEmptySettings, CopiedSchemePersisted)
{
auto newSchemeName = "My Copied Scheme";
// Make a copy of the default scheme
GlobalColourSchemeManager().copyScheme(SCHEME_DARKRADIANT_DEFAULT, newSchemeName);
// Export the state to the registry
GlobalColourSchemeManager().saveColourSchemes();
// Save to disk
GlobalRegistry().saveToDisk();
// Check the XML files if the colour was set
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
auto savedCopiedScheme = loadSchemeFromXml(newSchemeName, savedColoursFile);
auto savedDefaultScheme = loadSchemeFromXml(SCHEME_DARKRADIANT_DEFAULT, savedColoursFile);
EXPECT_EQ(savedCopiedScheme.size(), savedDefaultScheme.size());
// The values must be equal
for (const auto& pair : savedDefaultScheme)
{
EXPECT_EQ(savedCopiedScheme[pair.first], pair.second);
}
}
TEST_F(ColourSchemeTestWithIncompleteScheme, SchemeUpgrade)
{
// The colours.xml should be loaded and the missing colours should be added
auto missingColour = "selected_group_items";
auto& activeScheme = GlobalColourSchemeManager().getActiveScheme();
// Super Mal must be tagged as active
EXPECT_EQ(activeScheme.getName(), SCHEME_SUPER_MAL);
// The "selected_group_items" colour definition is missing in that file
// it should have been set to the defaults of the factory super mal
// Load the factory defaults
std::string defaultColoursFile = _context.getRuntimeDataPath() + "colours.xml";
EXPECT_TRUE(fs::exists(defaultColoursFile)) << "Could not find factory colours file: " << defaultColoursFile;
auto defaultScheme = loadSchemeFromXml(SCHEME_SUPER_MAL, defaultColoursFile);
EXPECT_EQ(defaultScheme[missingColour], activeScheme.getColour(missingColour).getColour());
// When saving, the scheme should now be complete
GlobalColourSchemeManager().saveColourSchemes();
GlobalRegistry().saveToDisk();
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
auto savedScheme = loadSchemeFromXml(SCHEME_SUPER_MAL, savedColoursFile);
EXPECT_EQ(savedScheme.size(), defaultScheme.size());
// All colour keys must be present
for (const auto& pair : savedScheme)
{
EXPECT_EQ(savedScheme.count(pair.first), 1);
}
}
TEST_F(ColourSchemeTestWithUserColours, RestoreActiveSchemeFromUserFile)
{
auto& activeScheme = GlobalColourSchemeManager().getActiveScheme();
// The "MyMaya" custom theme is tagged as active in the file
EXPECT_EQ(activeScheme.getName(), "MyMaya");
}
TEST_F(ColourSchemeTestWithUserColours, RestoreAllSchemesFromUserFile)
{
// Compare the schemes that we know are stored in the file
// The colours_userdefined.xml file specifically changes the "camera_background"
// colour in the SCHEME_BLACK_AND_GREEN theme, plus it adds a custom theme named MyMaya
auto storedSchemeNames = {
SCHEME_DARKRADIANT_DEFAULT,
SCHEME_QE3,
SCHEME_BLACK_AND_GREEN,
SCHEME_MAYA_MAX,
SCHEME_SUPER_MAL,
"MyMaya" // custom theme
};
for (auto schemeName : storedSchemeNames)
{
auto& loadedScheme = GlobalColourSchemeManager().getColourScheme(schemeName);
auto storedScheme = loadSchemeFromXml(schemeName, _userDefinedSchemePath.string());
// Check colour values
for (const auto& pair : storedScheme)
{
EXPECT_EQ(loadedScheme.getColour(pair.first).getColour(), pair.second);
}
}
}
TEST_F(ColourSchemeTestWithUserColours, SavedUserSchemesAreNotReadOnly)
{
// When saving user-defined schemes the readonly tag should only be present
// on the non-system themes
GlobalColourSchemeManager().saveColourSchemes();
GlobalRegistry().saveToDisk();
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
std::set<std::string> readOnlySchemes = {
SCHEME_DARKRADIANT_DEFAULT,
SCHEME_QE3,
SCHEME_BLACK_AND_GREEN,
SCHEME_MAYA_MAX,
SCHEME_SUPER_MAL
};
auto userScheme = "MyMaya";
xml::Document doc(savedColoursFile);
auto schemes = doc.findXPath("//colourscheme");
EXPECT_EQ(schemes.size(), readOnlySchemes.size() + 1); // readOnlySchemes + one user scheme
for (auto schemeNode : schemes)
{
auto name = schemeNode.getAttributeValue("name");
// Scheme should be read-only for the system ones only
EXPECT_EQ(schemeNode.getAttributeValue("readonly") == "1", readOnlySchemes.count(name) == 1);
}
}
TEST_F(ColourSchemeTestWithUserColours, ColourChangePersisted)
{
// This is the same test as TEST_F(ColourSchemeTestWithEmptySettings, SystemThemeColourChangePersisted) above
Vector3 newValue(0.99, 0.99, 0.99);
modifySchemeColour(SCHEME_DARKRADIANT_DEFAULT, "default_brush", newValue);
modifySchemeColour("MyMaya", "default_brush", newValue);
// Export the state to the registry and save it to disk
GlobalColourSchemeManager().saveColourSchemes();
GlobalRegistry().saveToDisk();
// Check the XML files if the colour was set
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
auto savedDefaultScheme = loadSchemeFromXml(SCHEME_DARKRADIANT_DEFAULT, savedColoursFile);
EXPECT_EQ(savedDefaultScheme["default_brush"], newValue);
auto savedUserScheme = loadSchemeFromXml("MyMaya", savedColoursFile);
EXPECT_EQ(savedDefaultScheme["default_brush"], newValue);
}
TEST_F(ColourSchemeTestWithUserColours, DeleteUserTheme)
{
std::string userThemeName = "MyMaya";
EXPECT_TRUE(GlobalColourSchemeManager().schemeExists(userThemeName));
GlobalColourSchemeManager().deleteScheme(userThemeName);
// Export the state to the registry and save it to disk
GlobalColourSchemeManager().saveColourSchemes();
GlobalRegistry().saveToDisk();
// Check the XML files if the scheme was actually removed
std::string savedColoursFile = _context.getSettingsPath() + "colours.xml";
EXPECT_TRUE(fs::exists(savedColoursFile)) << "Could not find saved colours file: " << savedColoursFile;
xml::Document doc(savedColoursFile);
auto schemes = doc.findXPath("//colourscheme[@name='" + userThemeName + "']");
EXPECT_TRUE(schemes.empty());
}
TEST_F(ColourSchemeTestWithUserColours, RestoreDeletedThemeFromRegistry)
{
std::string userThemeName = "MyMaya";
EXPECT_TRUE(GlobalColourSchemeManager().schemeExists(userThemeName));
// Delete the user theme
GlobalColourSchemeManager().deleteScheme(userThemeName);
EXPECT_FALSE(GlobalColourSchemeManager().schemeExists(userThemeName));
// Restore the changes from the registry
GlobalColourSchemeManager().restoreColourSchemes();
// The user theme should be there again
EXPECT_TRUE(GlobalColourSchemeManager().schemeExists(userThemeName));
}
TEST_F(ColourSchemeTestWithUserColours, RestoreChangedColourFromRegistry)
{
Vector3 newValue(0.99, 0.99, 0.99);
modifySchemeColour(SCHEME_DARKRADIANT_DEFAULT, "default_brush", newValue);
modifySchemeColour("MyMaya", "default_brush", newValue);
EXPECT_EQ(GlobalColourSchemeManager().getColourScheme("MyMaya").getColour("default_brush").getColour(), newValue);
EXPECT_EQ(GlobalColourSchemeManager().getColourScheme(SCHEME_DARKRADIANT_DEFAULT).getColour("default_brush").getColour(), newValue);
// Restore the changes from the registry
GlobalColourSchemeManager().restoreColourSchemes();
// The changes should be undone
EXPECT_NE(GlobalColourSchemeManager().getColourScheme("MyMaya").getColour("default_brush").getColour(), newValue);
EXPECT_NE(GlobalColourSchemeManager().getColourScheme(SCHEME_DARKRADIANT_DEFAULT).getColour("default_brush").getColour(), newValue);
}
TEST_F(ColourSchemeTestWithUserColours, ForeachScheme)
{
// Use a vector to record visited nodes to catch duplicate names
std::vector<std::string> visitedSchemes;
GlobalColourSchemeManager().foreachScheme([&](const std::string& name, colours::IColourScheme&)
{
visitedSchemes.push_back(name);
});
std::set<std::string> expectedSchemeNames = {
SCHEME_DARKRADIANT_DEFAULT,
SCHEME_QE3,
SCHEME_BLACK_AND_GREEN,
SCHEME_MAYA_MAX,
SCHEME_SUPER_MAL,
"MyMaya" // custom theme
};
EXPECT_EQ(expectedSchemeNames.size(), visitedSchemes.size());
for (auto expectedScheme : expectedSchemeNames)
{
EXPECT_EQ(std::count(visitedSchemes.begin(), visitedSchemes.end(), expectedScheme), 1);
}
}
}