eliminate the intermediate reader for the savegame pics.

ZDoom · Dec 14, 2023 · 3013239 · 3013239
1 parent 78a71bb
commit 3013239
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/src/common/menu/savegamemanager.cpp b/src/common/menu/savegamemanager.cpp
@@ -316,10 +316,7 @@ unsigned FSavegameManagerBase::ExtractSaveData(int index)
 		auto pic = resf->FindEntry("savepic.png");
 		if (pic >= 0)
 		{
-			FileReader picreader;
-			// we must create a memory reader copy of the PNG if we want to close the savegame file here.
-			auto rd = resf->Read(pic);
-			picreader.OpenMemoryArray(rd);
+			FileReader picreader = resf->GetEntryReader(pic, true);
 			PNGHandle *png = M_VerifyPNG(picreader);
 			if (png != nullptr)
 			{