- added an OnDestroy method to Shape2D so that its users can explicit…

…ly free the data it holds. In this case it is very important to care about management, because this class will hold GPU-side buffers!
ZDoom · Jul 25, 2021 · d8640d0 · d8640d0
1 parent 9e60613
commit d8640d0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/common/2d/v_2ddrawer.cpp b/src/common/2d/v_2ddrawer.cpp
@@ -528,8 +528,13 @@ void F2DDrawer::AddTexture(FGameTexture* img, DrawParms& parms)
 	offset = osave;
 }
 
-DShape2D::~DShape2D() {
-	delete lastParms;
+void DShape2D::OnDestroy() {
+	if (lastParms) delete lastParms;
+	lastParms = nullptr;
+	mIndices.Reset();
+	mVertices.Reset();
+	mCoords.Reset();
+	buffers.Reset();
 }
 
 //==========================================================================

diff --git a/src/common/2d/v_2ddrawer.h b/src/common/2d/v_2ddrawer.h
@@ -269,7 +269,7 @@ class DShape2D : public DObject
 	bool uploadedOnce = false;
 	DrawParms* lastParms;
 
-	~DShape2D();
+	void OnDestroy() override;
 };