Skip to content

Commit

Permalink
Changed Fatal Error Dialog title.
Browse files Browse the repository at this point in the history
This is to match all the parts that says GZDoom.
  • Loading branch information
AraHaan authored and coelckers committed Sep 22, 2017
1 parent 02fc585 commit e15a84f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/win32/zdoom.rc
Expand Up @@ -393,7 +393,7 @@ END
IDD_CRASHDIALOG DIALOGEX 0, 0, 415, 308
STYLE DS_SETFONT | DS_MODALFRAME | DS_SETFOREGROUND | DS_FIXEDSYS | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU
EXSTYLE WS_EX_CONTROLPARENT | WS_EX_APPWINDOW
CAPTION "ZDoom Very Fatal Error"
CAPTION "GZDoom Very Fatal Error"

This comment has been minimized.

Copy link
@Xane123

Xane123 Sep 23, 2017

Shouldn't things like this be GAMENAME "Very Fatal Error"? When people like me change the GAMENAME/GAMESIG variable, it should affect everything, not leave things like "Welcome to GZDoom!" and "GZDoom Very Fatal Error" behind. It makes those variables changable pointless when it doesn't change everything.

This comment has been minimized.

Copy link
@coelckers

coelckers via email Sep 23, 2017

Member
FONT 8, "MS Shell Dlg", 400, 0, 0x0
BEGIN
CONTROL "",IDC_CRASHTAB,"SysTabControl32",WS_TABSTOP,4,4,404,280
Expand Down

3 comments on commit e15a84f

@rautamiekka
Copy link

@rautamiekka rautamiekka commented on e15a84f Sep 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A precise source for the fatal error would be even better; GZDoom caused it ? The WAD/mod/pk3/... ? Or whichever caused it. We can selectively create that text, right ?

@alexey-lysiuk
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And how do you want to figure out the cause of unhandled exception?
Talk is cheap. Show me the code.

@rautamiekka
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ Just an idea and it's nearing impossible for me to create the code even if I tried.

Please sign in to comment.