- fixed memory leak in ZScript backend.

This allocated some memory and never freed it again. A TArray would have been better - but since we know the maximum size is 4 we may just use a static array here to keep things as efficient as possible.

src/common/scripting/backend/codegen.cpp

@@ -723,16 +723,17 @@ ExpEmit FxVectorValue::Emit(VMFunctionBuilder *build)
 	{
 		if (e) vectorElements++;
 	}
-	assert(vectorElements > 0);
+	assert(vectorElements > 0 && vectorElements <= 4);
 
-	ExpEmit* tempVal = (ExpEmit*)calloc(vectorElements, sizeof(ExpEmit));
-	ExpEmit* val = (ExpEmit*)calloc(vectorElements, sizeof(ExpEmit));
+	// We got at most 4 elements
+	ExpEmit tempVal[4];
+	ExpEmit val[4];
 
 	// Init ExpEmit
 	for (int i = 0; i < vectorElements; ++i)
 	{
-		new(tempVal + i) ExpEmit(xyzw[i]->Emit(build));
-		new(val + i) ExpEmit(EmitKonst(build, tempVal[i]));
+		tempVal[i] = ExpEmit(xyzw[i]->Emit(build));
+		val[i] = EmitKonst(build, tempVal[i]);
 	}
 
 	{