Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collectd 6]: Port epics plugin to 6.0 #4221

Open
matwey opened this issue Dec 31, 2023 · 5 comments
Open

[collectd 6]: Port epics plugin to 6.0 #4221

matwey opened this issue Dec 31, 2023 · 5 comments
Assignees
Milestone

Comments

@matwey
Copy link
Contributor

matwey commented Dec 31, 2023

Hello,

This is placeholder issue for porting epics plugin (see #4022) to collectd-6.

@matwey
Copy link
Contributor Author

matwey commented Jan 25, 2024

@octo so what is plugin_get_ds() alternative for 6.0?

@octo
Copy link
Member

octo commented Jan 25, 2024

@matwey There is no equivalent. Set the type field in metric_family_t to either METRIC_TYPE_COUNTER or METRIC_TYPE_GAUGE. The concepts of "data source name", minimum value, and maximum value no longer exist at all.

@matwey
Copy link
Contributor Author

matwey commented Jan 25, 2024

So I think I need also rethink the way the plugin configured.

@octo
Copy link
Member

octo commented Jan 25, 2024

I'm not familiar with the epics plugin, but at a glance it looks like the "label" concept adapts much nicer to collectd 6.

Strawman proposal for a configuration syntax, based on the v5 epics manpage entry:

<Plugin epics>
  <Family "cavity.temperature"> # metric family name
    Type "counter" # or "gauge"
    Unit "Cel" # for degrees celsius
    <Metric "Cavity1:Temp"> # where to read the value from
      Label "name" "Cavity1:Name" # populate additional metric labels
    </Metric>
  </Family>
</Plugin>

That's roughly what I'd focus on for a MVP version. We can add things like static labels or resource attributes later, if they are useful.

@octo octo added this to the 6.0 milestone Jan 25, 2024
@matwey
Copy link
Contributor Author

matwey commented Jan 25, 2024

Should we specify Type if we can infer it from the epics internal type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants