Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collectd 6] Missing "StoreRates" support for "write_http" plugin (regression from v5) #4263

Open
eero-t opened this issue Jan 30, 2024 · 0 comments

Comments

@eero-t
Copy link
Contributor

eero-t commented Jan 30, 2024

  • Version of collectd: v6-rc

Expected behavior

write_http plugin is documented to support StoreRates option, and does try to use it:

Actual behavior

Compiler warns that store_rates args is not used in format_json_metric_family(): https://github.com/collectd/collectd/blob/collectd-6.0/src/utils/format_json/format_json.c#L219

Notes

  • This regression from v5 functionality was introduced in eeb6ffa
  • write_http plugin is only user of that functionality, write_log sets it false:
$ git grep "format_json_metric_family *(" src/*.c
src/write_http.c:      format_json_metric_family(&cb->send_buffer, fam, cb->store_rates);
src/write_log.c:  int status = format_json_metric_family(&buf, fam, /* store rates = */ false);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants