Plone 5 compat

[simahawk]

What's the plan for this?

[ebrehault]

Hi @simahawk,
jbot works on Plone 5, we use on production (versions collective.jbot-1.0a3 + z3c.jbot-0.7.2).

[simahawk]

@ebrehault hi there! :)
Actually it doesn't... at least in my setup: I'm using the plone docs setup for plone 5 and is not, with those same versions :S

I'll test again w/ a more updated setup, thanks!

[simahawk]

@vangheem also: if it works for you we might update the README, since plone5 compat is on the roadmap? :)

[simahawk]

@ebrehault @jensens just tested again, I get this:

2015-10-09 09:11:37 ERROR Zope.SiteErrorLog 1444374697.710.252017125518 http://localhost:8080/Plone/++jbot++custom/@@jbot-editor
Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module Products.PDBDebugMode.runcall, line 70, in pdb_runcall
  Module ZPublisher.Publish, line 48, in call_object
  Module plone.app.theming.browser.mapper, line 49, in __call__
  Module Products.Five.browser.pagetemplatefile, line 125, in __call__
  Module Products.Five.browser.pagetemplatefile, line 59, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module 13f478c94820f5405c18e4481cf783cb.py, line 611, in render
  Module 1b3822954c2c9f8a5b29b2c0c38a7f48.py, line 854, in render_master
  Module 13f478c94820f5405c18e4481cf783cb.py, line 197, in __fill_head_slot
  Module five.pt.expressions, line 154, in __call__
  Module five.pt.expressions, line 126, in traverse
  Module zope.traversing.adapters, line 136, in traversePathElement
   - __traceback_info__: (<Products.Five.metaclass.SimpleViewClass from /home/simahawk/dev/.buildout/eggs/collective.jbot-1.0a3-py2.7.egg/collective/jbot/editor.pt object at 0x7ffaabc2aa90>, 'jsVariables')
  Module zope.traversing.adapters, line 50, in traverse
   - __traceback_info__: (<Products.Five.metaclass.SimpleViewClass from /home/simahawk/dev/.buildout/eggs/collective.jbot-1.0a3-py2.7.egg/collective/jbot/editor.pt object at 0x7ffaabc2aa90>, 'jsVariables', ())
LocationError: (<Products.Five.metaclass.SimpleViewClass from /home/simahawk/dev/.buildout/eggs/collective.jbot-1.0a3-py2.7.egg/collective/jbot/editor.pt object at 0x7ffaabc2aa90>, 'jsVariables')

 - Expression: "view/jsVariables"
 - Filename:   ... ollective.jbot-1.0a3-py2.7.egg/collective/jbot/editor.pt
 - Location:   (line 23: col 44)
 - Source:     ... javascript" tal:content="view/jsVariables"></script>
                                            ^^^^^^^^^^^^^^^^
 - Arguments:  repeat: {...} (0)
               template: <ViewPageTemplateFile - at 0x7ffaabe42c10>
               views: <ViewMapper - at 0x7ffaabe42850>
               modules: <instance - at 0x7ffab4bba3f8>
               args: <tuple - at 0x7ffabcba4050>
               here: <ImplicitAcquisitionWrapper Plone at 0x7ffaaeb5b500>
               user: <ImplicitAcquisitionWrapper - at 0x7ffaaeba9b90>
               loop: {...} (0)
               nothing: <NoneType - at 0x91a870>
               container: <ImplicitAcquisitionWrapper Plone at 0x7ffaaeb5b500>
               request: <instance - at 0x7ffaae7951b8>
               wrapped_repeat: <SafeMapping - at 0x7ffaabb072b8>
               traverse_subpath: <list - at 0x7ffaab91c3f8>
               default: <object - at 0x7ffabcac5500>
               context: <ImplicitAcquisitionWrapper Plone at 0x7ffaaeb5b500>
               view: <SimpleViewClass from /home/simahawk/dev/.buildout/eggs/collective.jbot-1.0a3-py2.7.egg/collective/jbot/editor.pt jbot-editor at 0x7ffaabc2aa90>
               translate: <function translate at 0x7ffaabdc0668>
               root: <ImplicitAcquisitionWrapper Zope at 0x7ffaad915c30>
               options: {...} (0)
               target_language: <NoneType - at 0x91a870>
> /home/simahawk/dev/.buildout/eggs/zope.traversing-3.13.2-py2.7.egg/zope/traversing/adapters.py(50)traverse()
-> raise LocationError(subject, name)

and this is because p.a.theming as changed a lot and that method is not there anymore. Are you sure you have the latest release of it?

[jensens]

oh, dears, i confused z3c.jbot with collective.jbot. sorry for any confusion. m( (deleted my above crap)

[pbauer]

😆

[simahawk]

@jensens :D

[ebrehault]

@simahawk ok I have just checked, we do have collective.jbot installed, but we do not use it (we just use z3c.jbot), and I get the same error than you if I try to use it.
Sorry.

[simahawk]

good :) then let's wait for @vangheem to wake up :)

[vangheem]

I haven't tried it yet; however, I'm really busy and won't have an opportunity to play with it before the conference :(

It's been a while since I looked at the code so I don't have much in the way of pointers. Sorry.

[ebrehault]

@simahawk the Diazo approach is working in Plone 5 (I mean: create a folder named "jbot" from the theming editor and then add templates properly named).
Consequently, don't you think we could remove the collective.jbot specific editor ?
I think the theming editor should be the unique place where we can customize stuffs in the theme, having a separate tool for viewlets is confusing.

The only problem is we loose the Search Resources feature.