Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation for ctkDirectoryButton::Option and ctkDirectoryButton::Option enums #1129

Open
jcfr opened this issue Jul 26, 2023 · 0 comments

Comments

@jcfr
Copy link
Member

jcfr commented Jul 26, 2023

After integrating pull request

We observed that project directly using the enum failed to build:

/path/to/Slicer-Release/Slicer-build/Modules/Scripted/DICOMLib/Widgets/ui_qSlicerDICOMExportDialog.h:185:64: error: ‘ShowDirsOnly’ is not a member of ‘ctkPathLineEdit’
  185 |         PathLineEdit_OutputFolder->setOptions(ctkPathLineEdit::ShowDirsOnly);
      |                                                                ^~~~~~~~~~~~

See Slicer/Slicer#7127 (comment)

Considering that ctkDirectoryButton and ctkPathLineEdit both derive from QWidget and user code may use references to option like ctkPathLineEdit::ShowDirsOnly (instead of QFileDialog::ShowDirsOnly), this was reverted through the integration of:

To support existing use case, the old API should instead be deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant