Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choosing blog attribute topic causing parse error #2675

Closed
zanedev opened this issue Jul 7, 2015 · 14 comments
Closed

Choosing blog attribute topic causing parse error #2675

zanedev opened this issue Jul 7, 2015 · 14 comments

Comments

@zanedev
Copy link
Contributor

zanedev commented Jul 7, 2015

after adding some custom blog post attributes and trying to assign them to a page there is parse error shown in place of the blog attribute:

image

After further debugging it appears that the $_REQUEST['treeNodeParentID'] being sent to the backend is not a valid tree node, it does not exist as a valid tree node id in the TreeNodes table. I've verified this on two separate installs of C5 5.7.4.2 on linux.

Steps to reproduce:

  1. Add some new topic attributes in system settings
  • go to dashboard then attributes then topics
  • add new and name it whatever and save
  1. Attempt to add blog entry topics to a page attributes
  • go to a page attributes then attempt to add the newly created topic attribute and see the error on the page similar to the screenshot

Browser console shows:
SyntaxError: Unexpected end of input
at Object.parse (native)
at m.parseJSON (http://localhost/concrete5.7.4.2/concrete/js/jquery.js:5:15998)
at Pb (http://localhost/concrete5.7.4.2/concrete/js/jquery.js:5:18379)
at x (http://localhost/concrete5.7.4.2/concrete/js/jquery.js:5:21793)
at XMLHttpRequest.m.ajaxTransport.send.b (http://localhost/updates/concrete5.7.4.2/concrete/js/jquery.js:5:26030)

@aembler
Copy link
Member

aembler commented Jul 8, 2015

It appears from your error message that this is being done with 5.7.4.2. 5.7.4.2 bugs ought to go in the concrete5.org bug tracker. I believe this is likely to a bug that has been fixed in our develop branch for awhile, where new topic attributes aren't working in 5.7.4.2. This will be publicly fixed in a release very soon.

@aembler aembler closed this as completed Jul 8, 2015
@zanedev
Copy link
Contributor Author

zanedev commented Jul 10, 2015

Okay wasn't sure where to file it. I did file it also on the concrete5.org bug tracker so I will close that if it's indeed fixed after the next public release.

@aembler
Copy link
Member

aembler commented Jul 10, 2015

No worries, thanks! We hope to get a release candidate out for 5.7.5 very soon, which you'll be able to upgrade to.

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

This is still a bug in 5.7.5, can't seem to reopen here if someone want's to reopen it..

@aembler
Copy link
Member

aembler commented Aug 13, 2015

The original "steps to reproduce" aren't really that helpful. I think
you're going to need to actually start with a fresh install and detail the
exact steps, including which screens you visited, in order to reproduce the
bug. The steps as listed are vague.

On Thu, Aug 13, 2015 at 10:47 AM, ZaneDev notifications@github.com wrote:

This is still a bug in 5.7.5, can't seem to reopen here if someone want's
to reopen it..


Reply to this email directly or view it on GitHub
#2675 (comment)
.

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

Interesting.. seems pretty clear to me if you know the system it really is that simple reproduce. This was done on a fresh install at the time. I even added debug information.

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

Added more detail on the steps hope that clears it up for ya

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

Just had a client verify it is still happening on 5.7.5... Might want to reopen this and take a look. Let me know if you need more info.

@joe-meyer
Copy link
Contributor

Ya I can't verify this either. I took what steps I see you listed:

image

All working just fine for me.

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

Ok maybe it's from the upgrade somehow or the environment I'll do some more investigation

@aembler
Copy link
Member

aembler commented Aug 13, 2015

Could it be the name of a topic you added? Do they have apostrophes or
special characters in them?

On Thu, Aug 13, 2015 at 2:28 PM, ZaneDev notifications@github.com wrote:

Ok maybe it's from the upgrade somehow or the environment I'll do some
more investigation


Reply to this email directly or view it on GitHub
#2675 (comment)
.

@zanedev
Copy link
Contributor Author

zanedev commented Aug 13, 2015

Nope just simple names.. I'll dig in further and figure it out and report back. Thanks for trying it out guys I'll get some more specifics from the client and repro myself on a clean install.

@OKDnet
Copy link

OKDnet commented Aug 25, 2015

I just got this error, on 5.7.5.1 installation

On my home page
"Call to a member function getRootTreeNodeObject() on a non-object"

Steps to reproduce (as best as I can remember, but it was a new install).

1- Installed 5.7.5.1 with sample content.
2- Installed Long Way Home theme
https://www.concrete5.org/marketplace/themes/long-way-home1/
IMPORTANT: This theme gives the option to remove all existing site content (so the sample content), and replace it with it's own. I did this.
3- On the home page, there is a Topic List Block (under "Galleries and Portfolios and above the Page List Block). I was playing with those settings (Mode & Topic Tree).

Step 3 is what did it (combined with the removal of content, judging from Andrews comment perhaps a topic was removed). Note: That block is using a custom template from the theme called "Long Way Home Animated Filter"

I hope this helps.

@joe-meyer
Copy link
Contributor

@OKDnet you should open a support ticket with the theme developer. Since it's a paid addon it's not something that community contributors can simply download and review source code. If the theme developer things that there is a core problem they should submit a big report with details on the code that's problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants