Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Site name and page title on default #3801

Merged
merged 1 commit into from Jul 18, 2016
Merged

Switch Site name and page title on default #3801

merged 1 commit into from Jul 18, 2016

Conversation

katzueno
Copy link
Contributor

Japanese users and I was also wondering why the page title order default has been
SITE NAME :: PAGE NAME
I would like to propose to switch to PAGE NAME :: SITE NAME order by default.
By changing the /concrete/config/concrete.php

Request from Japanese users
http://concrete5-japan.org/community/forums/feature-requests/post-13251/

They want to comply the site to meet WCAG standard
https://www.w3.org/TR/WCAG20-TECHS/G88.html
https://www.w3.org/WAI/WCAG20/quickref/#qr-navigation-mechanisms-title

Thanks.

@aembler aembler added type:discussion Type:Enhancement A need for something new. Status:Available Reviewed issue, it’s real, we’d review a pull request. and removed type:discussion labels May 16, 2016
@aembler
Copy link
Member

aembler commented May 16, 2016

We'd support this

@milk54
Copy link

milk54 commented Jul 14, 2016 •
edited

Thank you. I'm Japanese users.
As one of the reasons, titles are should be able to identifying individual page information by bookmark and browser tab on the accessibility.
And The proposed new standard for Section 508 is expected to require conformance to the W3C Web Content Accessibility Guidelines (WCAG) 2.0 Level AA.
http://www.section508.gov/content/build/website-accessibility-improvement/WCAG-conformance

Please come down by all means.

@katzueno
Copy link
Contributor Author

Sorry, I was too lazy to send very simple PR for long time.
Here you go.

@aembler aembler merged commit 880e337 into concretecms:develop Jul 18, 2016
@katzueno katzueno deleted the seo-page-title-order branch July 20, 2016 02:45
KorvinSzanto pushed a commit that referenced this pull request Dec 12, 2016
@katzueno @aembler
Change the default page title order to [Page Title} :: [Site Name] (#…
7b34acb 
…3801)

Former-commit-id: 880e337
Former-commit-id: 6e05c9a47cbb45e834d4d9e99c7ac0cd9d3f2d28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Enhancement A need for something new.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@katzueno @aembler @milk54