[5.7.5.9][V8] File Versions doesn't delete unapproved version files physically

[katzueno]

Confirmed with both 5.7.5.9 and Version 8.0b6.

Steps to reproduce

• Visit File Manager
• Click one of the existing file
• Click Replace
• Choose and upload a file to replace the file
• Click that file and select Properties
• Click Version tabs
• Delete the older version of the file
  
• The older version of file still physically existed under /application/files
  

I had to go through the site with a lots of file's older versions deleted.. but still eating up the disk spaces of the server...

Deleted file version should be deleted.

Thanks

[aembler]

This is the intended behavior; from the comments of the Version::delete() method:

Removes a version of a file. Note, does NOT remove the file because we don't know where the file might elsewhere be used/referenced.

The method takes as boolean parameter to delete the physical files, which is what we do when we remove the entire File object. I assume this is because we didn't easily know if the version object was actually a completely new file or just a text change (if it's a text change, when deleting the file version we obviously don't want to remove the file.)

[aembler]

This is fixed in 8.4.2 #6887

[katzueno]

Just read the release note. Thank you @mlocati !