Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Basic Workflow notification email's FROM address to be configurable from config/concrete.php #4991

Closed
katzueno opened this issue Jan 22, 2017 · 2 comments

Comments

@katzueno
Copy link
Contributor

katzueno commented Jan 22, 2017

@kanetei requested that he would like to set the Basic Workflow From email address rather than super admin's email. He said he would like it to be configurable from config/concrete.php which I also think it would come in handy.

https://concrete5-japan.org/community/forums/usage/post-14614/

I propose to use

concrete.email.default.address and concrete.email.default.name if it's set
and create
concrete.email.basicworkflow.name andconcrete.email.basicworkflow.address if someone wants to use the address rather than default from email address.

Thanks.

@katzueno katzueno changed the title Make Basic Workflow From Email address to be configurable from config/concrete.php Make Basic Workflow FROM email address to be configurable from config/concrete.php Jan 22, 2017
@katzueno katzueno changed the title Make Basic Workflow FROM email address to be configurable from config/concrete.php Make Basic Workflow notification email's FROM address to be configurable from config/concrete.php Jan 22, 2017
@aembler
Copy link
Member

aembler commented Jan 23, 2017

Sounds good to me.

@katzueno
Copy link
Contributor Author

katzueno commented Oct 5, 2017

PR submitted #5942

@katzueno katzueno closed this as completed Oct 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants