Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect day of week checkbox checked on repetition #5955

Closed
aembler opened this issue Sep 13, 2017 · 3 comments
Closed

Incorrect day of week checkbox checked on repetition #5955

aembler opened this issue Sep 13, 2017 · 3 comments
Labels
Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.

Comments

@aembler
Copy link
Member

aembler commented Sep 13, 2017

When using the repetition selector (as in the calendar add-on) if you choose to repeat an event on every Monday, then change the date to a Tuesday and re-save without having changed the day of the week checkbox to Tuesday, when you edit the event the tuesday checkbox will be checked – even though Monday is actually still saved in the repetition. This is because the same JS runs on Add as does on Edit – we need to disable this in onActivateDates in the repetition.js.
@aembler aembler added Status:Available Reviewed issue, it’s real, we’d review a pull request. priority:love to have Type:Bug Existing functionality not performing as expected. labels Sep 13, 2017
@katzueno
Copy link
Contributor

It could be the similar issue.
(It's very confusing... so I'll just leave the symptom here)

Originally reported at Japanese forum
https://concrete5-japan.org/community/forums/bug/post-18139/#18163

  1. Create an event
  2. Click Repeat Event, Every Week
  3. Check Friday
  4. Publish an event
  5. Click the published event and edit
  6. Keep checking Friday, but add Monday and Tuesday
  7. Publish the event, however, the change didn't get to apply.

Is the above symptom related to this issue?

Thanks.

@aembler
Copy link
Member Author

aembler commented Jun 25, 2019

Duped by #7851

@aembler
Copy link
Member Author

aembler commented Jun 25, 2019

This is now resolved and will be released in 8.5.2

@aembler aembler closed this as completed Jun 25, 2019
@daniel-keller daniel-keller mentioned this issue Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@katzueno @aembler