Page Not Found page doesn't respect default site locale

[hissy]

If you access to YOUR_SITE/page_not_found, the active locale is the same as the default site.
However, if you access to YOUR_SITE/foo (or any other missing URLs), the active locale is always en_US.
Please see the attached image. Tested on 8.5.2a1.

This is a very similar issue with #6500, but it happens on non-multilingual site.

[aembler]

Can you describe the setup here? Is this a site where you have a custom language set for concrete5? Is this a site with Japanese set as the language but no other multilingual locales? Just trying to understand what's happening here.

[hissy]

Tested on clean installed concrete5 with the guest account.

+---------------------------+-------------------+
| Question                  | Value             |
+---------------------------+-------------------+
| language                  | ja_JP             |
| site-locale               | ja_JP             |
+---------------------------+-------------------+

/page_not_found : lang=ja
/foo : lang=en

+---------------------------+-------------------+
| Question                  | Value             |
+---------------------------+-------------------+
| language                  | ja_JP             |
| site-locale               | en_US             |
+---------------------------+-------------------+

/page_not_found : lang=ja
/foo : lang=en

+---------------------------+-------------------+
| Question                  | Value             |
+---------------------------+-------------------+
| language                  | en_US             |
| site-locale               | ja_JP             |
+---------------------------+-------------------+

/page_not_found : lang=en
/foo : lang=en

+---------------------------+-------------------+
| Question                  | Value             |
+---------------------------+-------------------+
| language                  | en_US             |
| site-locale               | en_US             |
+---------------------------+-------------------+

/page_not_found : lang=en
/foo : lang=en

[hissy]

This issue is reported on Japanese forum
https://concrete5-japan.org/community/forums/chat/post-18212/

[hissy]

A new and same report from Japanese forum
https://concrete5-japan.org/community/forums/development/post-18446/

[africanforest]

I can confirm this issue (version 8.5.4, German language as default). While a customized login page is always automatically translated to the default language of the site, the Page Not Found page always appears in English, no matter which way of customization you go (custom single page or page_not_found.php within the theme). In this case the T-Strings will not be translated.

[hissy]

@mlocati

I have a question for you. You moved setupSiteInterfaceLocalization() after the redirection at the commit ca0970b . Is there any reason to do that? Because I'm planning to move it to the earlier position in \Concrete\Core\Http\ResponseFactory::collection method to fix this issue. I'd like to know why you moved it later.

[mlocati]

@hissy the actual commit is b1e4dbf (see its comment for the reason)

[hissy]

@mlocati Thanks. So, we shouldn't call setupSiteInterfaceLocalization before getting multilingual_default_locale from the session, right?

[mlocati]

Yes, I'm pretty sure that's the reason why I moved setupSiteInterfaceLocalization down a few lines (but really, I can't remember what I ate yesterday, how could I remember what I did 4 years ago? 😉)

[hissy]

OK, I'll check. Thanks!