Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Even though you activate the user who gets inactivated by failing to log in, the login count is not cleared. #8449

Closed
nakazawazakan opened this issue Mar 9, 2020 · 3 comments
Closed

Even though you activate the user who gets inactivated by failing to log in, the login count is not cleared. #8449

nakazawazakan opened this issue Mar 9, 2020 · 3 comments
Labels
Affects:Content Creators Affects those who use the UI to create or edit content. Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Product Areas:Authentication & Login Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.

Comments

@nakazawazakan
Copy link
Contributor

nakazawazakan commented Mar 9, 2020 •
edited

We have tested in the following steps.

  1. At user deactivation settings, activate "Automatically deactivate users after failed login attempts."
    user_deactivation_settings

  2. Fail to login by filling out the wrong password. You'll get the alert message at login page.
    inactive user

  3. Activate the user at Members page.
    member page

Screen Shot 2020-03-09 at 15 58 19

  1. You can login with the user, but probably because the login count is not cleared, once the user fails to log in, he or she gets inactivated again.
@aembler aembler added Affects:Content Creators Affects those who use the UI to create or edit content. Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Product Areas:Authentication & Login Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected. labels Mar 11, 2020
@Dthomas810
Copy link

Hey, pretty new to open source, do I just comment here to claim issues? I see it in the guidelines but wasn't sure if it's still how it's being handled from looking at recently closed stuff.

@aembler
Copy link
Member

aembler commented Apr 8, 2020

@Dthomas810 Yes, please feel free to just comment on issues to claim that you're working on them!

@arielkamoyedji arielkamoyedji mentioned this issue Apr 9, 2020
Merged
aembler added a commit that referenced this issue Nov 12, 2020
@aembler
Merge pull request #8528 from arielkamoyedji/fix/#8449
78d0e0c 
Fixed : Even though you activate the user who gets inactivated by fai…
@hissy
Copy link
Contributor

hissy commented Nov 25, 2020

The related pull request is already merged. We may be able to close this issue.

@aembler aembler closed this as completed Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects:Content Creators Affects those who use the UI to create or edit content. Bug Priority:Low This would be a nice fix, but it mildly improves things that already work. Product Areas:Authentication & Login Status:Available Reviewed issue, it’s real, we’d review a pull request. Type:Bug Existing functionality not performing as expected.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hissy @aembler @Dthomas810 @nakazawazakan