Changing default calendar permissions is broken

[core77]

If you want to change the default calendar permissions in Dashboard/System&Settings/Calendar/Permissions the URL provided in this file does't work:
https://github.com/concrete5/concrete5/blob/develop/concrete/elements/permission/details/calendar_admin.php#L10

When you click on, lets say "View calendars" on the dashboard page, you get the error ".../concrete/elements/permission/details/calendar_admin.php:10 Call to a member function getID() on null (0)"

This error didn't come up in version 8.5.2 but occurs in 8.5.4 and 9.0.0a3.

Seems like the calendar ID (caID) is only needed if you edit a specific calendar's permissions in Dashboard/Calendars & Events but it's not needed if you edit the default permissions in Dashboard/System&Settings/Calendar/Permissions.

[katzueno]

Confirmed by a Japanese user and reported to the Japanese forum
https://concrete5-japan.org/community/forums/beginner/post-19483

Error trace

Call to a member function getID() on null

詳細

/xxx/concrete/elements/permission/details/calendar_admin.php(10): Error->null
/xxx/concrete/src/View/View.php(476): null->include
/xxx/concrete/src/Legacy/Loader.php(39): Concrete\Core\View\View->element
/xxx/concrete/views/dialogs/permissions/calendar_admin.php(6): Concrete\Core\Legacy\Loader->element
/xxx/concrete/src/View/View.php(267): null->include
/xxx/concrete/src/View/View.php(245): Concrete\Core\View\View->renderInnerContents
/xxx/concrete/src/View/AbstractView.php(164): Concrete\Core\View\View->renderViewContents
/xxx/concrete/src/Routing/ControllerRouteAction.php(75): Concrete\Core\View\AbstractView->render
/xxx/concrete/src/Http/RouteDispatcher.php(37): Concrete\Core\Routing\ControllerRouteAction->execute
/xxx/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\RouteDispatcher->dispatch
/xxx/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\DispatcherDelegate->next
/xxx/concrete/src/Http/DefaultDispatcher.php(125): Concrete\Core\Http\Middleware\MiddlewareStack->process
/xxx/concrete/src/Http/DefaultDispatcher.php(58): Concrete\Core\Http\DefaultDispatcher->handleDispatch
/xxx/concrete/src/Http/Middleware/DispatcherDelegate.php(39): Concrete\Core\Http\DefaultDispatcher->dispatch
/xxx/concrete/src/Http/Middleware/ThumbnailMiddleware.php(76): Concrete\Core\Http\Middleware\DispatcherDelegate->next
/xxx/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ThumbnailMiddleware->process
/xxx/concrete/src/Http/Middleware/FrameOptionsMiddleware.php(39): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/xxx/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\FrameOptionsMiddleware->process
/xxx/concrete/src/Http/Middleware/CookieMiddleware.php(35): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/xxx/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\CookieMiddleware->process
/xxx/concrete/src/Http/Middleware/ApplicationMiddleware.php(29): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/xxx/concrete/src/Http/Middleware/MiddlewareDelegate.php(50): Concrete\Core\Http\Middleware\ApplicationMiddleware->process
/xxx/concrete/src/Http/Middleware/MiddlewareStack.php(86): Concrete\Core\Http\Middleware\MiddlewareDelegate->next
/xxx/concrete/src/Http/DefaultServer.php(85): Concrete\Core\Http\Middleware\MiddlewareStack->process
/xxx/concrete/src/Foundation/Runtime/Run/DefaultRunner.php(128): Concrete\Core\Http\DefaultServer->handleRequest
/xxx/concrete/src/Foundation/Runtime/DefaultRuntime.php(102): Concrete\Core\Foundation\Runtime\Run\DefaultRunner->run
/xxx/concrete/dispatcher.php(45): Concrete\Core\Foundation\Runtime\DefaultRuntime->run
/xxx/index.php(3): null->require

Also confirmed on my freshly installed local 8.5.4

[hissy]

#8534 is the reason for this error.

[hissy]

The same error reported on Slack.
https://concrete5.slack.com/archives/CDJ4G93C3/p1617864602150500

Why this issue closed silently?

[hissy]

I believe this issue is not fixed yet. Tested on recent 8.5.x branch

[aembler]

It was closed because @KorvinSzanto said he fixed the issue already.

[hissy]

@aembler Thanks for the reply, could you re-open it?

[hissy]

It might be fixed already on develop branch. Need to test

[aembler]

This has since been fixed.