Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrading JQuery and JQuery UI due to a security vulnerability #7812

Merged
merged 1 commit into from May 15, 2019

Conversation

mesparza5
Copy link
Contributor

Vulnerability reports shows that jQuery versions on or above 1.4.0 and below 1.12.0 (version 1.12.3 and above but below 3.0.0-beta1 as well) are vulnerable

@aembler aembler merged commit 9510d13 into concretecms:develop May 15, 2019
@hissy
Copy link
Contributor

hissy commented Jul 16, 2019

FYI: this is the reason why only 1.12.2 is not vulnerable

jquery/jquery#2432 (comment)

@biplobice
Copy link
Contributor

biplobice commented Jul 16, 2019

jquery-ui.js has version 1.12.1
https://github.com/concrete5/concrete5/blob/b796a150ddc986923133712383b8dd3f28875a22/concrete/js/jquery-ui.js#L1

But the jquery-ui.css has version 1.11.4
https://github.com/concrete5/concrete5/blob/308e0cfacac522dd39bc920b55be1ca5dd8d5633/concrete/css/jquery-ui.css#L1

I think the CSS also supposed t obe 1.12.1, but it got changed by the [skip ci] Automatic assets rebuilding

jquery-ui.css changes history

@mesparza5
Copy link
Contributor Author

Totally forgot we needed to upgrade the jquery-ui.less from 1.11.4 to 1.12.1. I just submitted a new PR with this update.

@mlocati mlocati mentioned this pull request Aug 19, 2019
acohin pushed a commit to acohin/concrete5 that referenced this pull request Feb 9, 2020
…-Libraries

Downgrading JQuery and JQuery UI due to a security vulnerability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants