Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the calculated port when useBindPortIP is enabled #6199

Merged
merged 2 commits into from Jan 20, 2020
Merged

Use the calculated port when useBindPortIP is enabled #6199

merged 2 commits into from Jan 20, 2020

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 19, 2020 •
edited by mpl

What does this PR do?

Fix #6187

Motivation

When using useBindPortIP, we were using the indicated port instead of the calculated port.

More

  • Added/updated tests
    - [ ] Added/updated documentation

@juliens juliens requested a review from ldez January 19, 2020 11:35
@traefiker traefiker added this to the 2.1 milestone Jan 19, 2020
@ldez ldez removed the area/service label Jan 19, 2020
@ldez ldez added this to To review in v2 via automation Jan 19, 2020
ldez
ldez approved these changes Jan 19, 2020
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mpl mpl changed the title Use the calculated port when useBindPortIP is enable Use the calculated port when useBindPortIP is enabled Jan 20, 2020
dtomcej
dtomcej approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

@traefiker traefiker merged commit f84d947 into traefik:v2.1 Jan 20, 2020
v2 automation moved this from To review to Done Jan 20, 2020
@traefiker traefiker mentioned this pull request Jan 20, 2020
Closed
@juliens juliens deleted the fix-usebindportip branch April 23, 2021 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpl mpl mpl approved these changes

@ldez ldez ldez approved these changes

@dtomcej dtomcej dtomcej approved these changes

Assignees
No one assigned
Labels
area/provider/docker kind/bug/fix a bug fix size/S
Projects
No open projects
v2
Done
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juliens @mpl @ldez @dtomcej @traefiker