New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVG images support #222

Open

arnisjuraga opened this issue Aug 16, 2019 · 0 comments

Labels

enhancement security

Contributor

arnisjuraga commented Aug 16, 2019 •

edited

I have added SVG image support for site logo c6dc058.

But this issue is more complicated.

~~.SVG should be handled inside model_tool_image->resize methods (resizing ignored, if SVG image received).~~

Adding SVG support is easy. The problem comes with security. Many of CMS does not allow svg by default.
Implementing this, I faced 2 main problems

how to deal with a security? Or everything is already protected inside browsers?
SVG image upload returns incorrect MIME types for different browsers/OS.

SVG should be disabled for files upload from Catalog side.

Other references:
opencart/opencart#6764
opencart/opencart#3064 (Svg in categories)
opencart/opencart#5411 (@danielkerr: svg is not an image format!)
opencart/opencart#3724 (@danielkerr:svg is jot supported its also not an image)
https://core.trac.wordpress.org/ticket/24251 (Wordpress SVG security chat)
https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing

The text was updated successfully, but these errors were encountered:

arnisjuraga added enhancement security labels

arnisjuraga added a commit that referenced this issue


          SVG support added in catalog, and model_tool_image level #222

6361daa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment