Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect mutual exclusion of boolean variables in the code #28

Open
skhakimov opened this issue Jul 23, 2015 · 1 comment
Open

Reflect mutual exclusion of boolean variables in the code #28

skhakimov opened this issue Jul 23, 2015 · 1 comment

Comments

@skhakimov
Copy link
Contributor

By design boolean variables 'direct_network_exposure', 'process_network_data' and 'potential_privilege_escalation' are mutually exclusive. That is, one of these variables must be selected. Currently the code doesn't reflect that.

@david-a-wheeler
Copy link
Contributor

Clarification: Obviously it's possible for software to have all 3 of direct network exposure, process network data, and privilege escalation. However, the idea was that in the risk score, only one of them (the worst) was used. To implement this, data was created so that only one (the worst) was set to 1, and the rest were 0... so the data values were mutually exclusive. In retrospect, this wasn't the best choice; this turns out to be confusing and doesn't capture the real situation as accurately as we'd like. So instead, let's force the calculation to only use the "worst" value, and that way, data entry doesn't have to enforce a mutual-exclusive rule. In the long run it might be best to go back and update the data so that it no longer requires mutual exclusivity, and then we might refine the metric further... but this will keep the intent of the current rule and avoid confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants