Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work where Wiki just uses "$auth->getUserData(...)" #8

Open
einhirn opened this issue Jan 26, 2012 · 1 comment
Open

Doesn't work where Wiki just uses "$auth->getUserData(...)" #8

einhirn opened this issue Jan 26, 2012 · 1 comment

Comments

@einhirn
Copy link
Contributor

einhirn commented Jan 26, 2012

Hello,
I just found out that this plugin doesn't work well with email subscriptions. Subscription processing switches to the subscribed user via $auth->getUserData before doing an auth_quickaclcheck for the ID in question. Since this plugin doesn't hook $auth's methods but rewrites $USERINFO later on, users that only have access via virtualgroup won't ever get an email notifier.

It should probably be possible to create kind of a "passthrough" auth class that just queries the original ones (of course rewriting the list of groups returned) and put that into "$auth". That way, in my opinion, it should be possible to intercept calls to $auth->getUserData.

If there is a way to hook $auth even before the user is first authenticated and the session is built, we could even do without rewriting the group array later on.

bye
Christian

@einhirn
Copy link
Contributor Author

einhirn commented Dec 11, 2015

Probably will try to rewrite this plugin to be an auth plugin which in turn calls another auth plugin, so it can modify group membership properly. Come time, come code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant