Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Bar (Ctrl+F) does not search nicknames #446

Closed
claucece opened this issue Sep 25, 2017 · 4 comments
Closed

Search Bar (Ctrl+F) does not search nicknames #446

claucece opened this issue Sep 25, 2017 · 4 comments
Labels
ux
Projects
Next release

Comments

@claucece
Copy link
Contributor

Currently, the search Bar (shown by Ctrl+F) only searches by account (i.e, bla@jabber.cryptoparty.is) but not by nickname. It should also search by nickname.
@claucece claucece changed the title Search Bar (Ctrl+F) does not search account names Search Bar (Ctrl+F) does not search nicknames Sep 25, 2017
@claucece claucece added the ux label Oct 12, 2017
@juniorz
Copy link
Member

juniorz commented Nov 1, 2017

Also the search will use the default GtkTreeViewSearchEqualFunc on the tree view.

It would be nice to make it more flexible. Searching for ola should match ola@gmail.com and also paola@gmail.com. This is also helpful to searching for contacts on certain servers.

@juniorz
Copy link
Member

juniorz commented Nov 1, 2017

Look at:

  • gtk_tree_view_set_search_equal_func ()
  • g_str_match_string()

juniorz pushed a commit that referenced this issue Nov 1, 2017
Use tooltip column for search.
c0fe067 
In preparation for allowing more flexible searches.

See: #446
@tdruiva
Copy link
Contributor

tdruiva commented Nov 1, 2017

Tips:

  • Ctrl+g: next result (key arrow down)
  • Ctrl+G: previous result (key arrow down)

@claucece
Copy link
Contributor Author

claucece commented Nov 2, 2017

Currently, search bar is also unable to search for contacts with '_' on them. It will search 'sofi' but not 'sofi_celi' on sofi_celi@jabber.cryptoparty.is.

@juniorz juniorz added this to the 0.4.0 Release milestone Nov 7, 2017
@juniorz juniorz added this to to do in Next release Nov 10, 2017
@juniorz juniorz removed this from to do in Next release Nov 10, 2017
@juniorz juniorz added this to to do in Next release Nov 10, 2017
@juniorz juniorz moved this from to do to in progress in Next release Nov 10, 2017
@tdruiva tdruiva mentioned this issue Nov 10, 2017
Merged
@tdruiva tdruiva moved this from in progress to test in Next release Nov 14, 2017
@tdruiva tdruiva closed this as completed Nov 21, 2017
@claucece claucece moved this from test to done in Next release Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ux
Projects
Next release
done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@juniorz @tdruiva @claucece