Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hyperparameter parsing #295

Open
cpnota opened this issue Feb 11, 2024 · 0 comments
Open

Improve hyperparameter parsing #295

cpnota opened this issue Feb 11, 2024 · 0 comments
Labels
Milestone

Comments

@cpnota
Copy link
Owner

cpnota commented Feb 11, 2024

Right now, we have a repeated piece of code:

    hyperparameters = {}
    for hp in args.hyperparameters:
        key, value = hp.split('=')
        hyperparameters[key] = type(agent.default_hyperparameters[key])(value)
    agent = agent.hyperparameters(**hyperparameters)

First of all, this would be better as a dict comprehension. Second of all, I think agent.hyperparameters could handle the type conversion in a more general way, instead of making the script do it.

@cpnota cpnota added this to the ALL Next milestone Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant