New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid class between Tag as class and Tag as type #33
Comments
Can you share the code you're working on? I'd like to see how you ran into the clash with types. My intent was that the tag types would be used qualified (since you need to know which tag type you're using) or use the type class API (since if you don't know the specific type, then you can't rely on anything more specific). However, that's skewed by my perspective--it probably makes more sense while working on the library, than it would on a specific app where you likely only use one tag type. When adding a new POS tag set, you will have to duplicate the I can probably help more if I could take a look at your code! I want to be sure I understand how you're using the library before making changes. Thanks for pointing out the qualified imports in Conll! I'll fix that shortly. |
dear creswick - thank you for looking into it. I understand how to add POS tag sets and how to instantiate them for the class Tag. Obviously I select different names for each tagset (at the moment I try to find out which tag set a coreNLP model uses....(:-) and build them). |
I have a follow up question: how should one deal with combined POS tags like |
I have difficulties using
chatter
when I extend it with other POS tags and had to copy thedata Tag ..
verbatim to my code. The nametag
is used multiple times, first as class and then as type in Conll and Brown. ExportingTag(..)
fromNLP.Types
andNLP.Corpora.Conll
produces the clash.I would recommend to change the class name as
Tags
and to change the type names to ConllTag and BrownTag.(by the way, in NLP.Corpora.Conll there are two qualified imports as T (Data.Text and NLP.Types.Tags))
thank you!
andrew
The text was updated successfully, but these errors were encountered: