Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of page param doesn't change. #16

Open
kresnasatya opened this issue Oct 23, 2019 · 3 comments
Open

Value of page param doesn't change. #16

kresnasatya opened this issue Oct 23, 2019 · 3 comments

Comments

@kresnasatya
Copy link
Contributor

Hi @cristianbote, I try hnpwa-vanilla live site doesn't update the value of param page each time I move to the next page. Here is the demo video related to the value of page param doesn't change.

@cristianbote
Copy link
Owner

Hi @satyakresna! :) thanks for checking it out! Hmm that's odd. No errors in console? I tried just now on incognito as well, and it did work. Wondering if there's more to it. Like some kind of error.

@kresnasatya
Copy link
Contributor Author

kresnasatya commented Oct 23, 2019

Hi @cristianbote, thanks for the reply. I checked there are no errors in the console. Although there is no error in the web interface and functionality, it bit weird when navigating to the next page and value of page params doesn't change.

Example: I was in top link and move to news link. When I go to next page in news link, it should be news?page=2 instead of news=?page=1 in address bar. But, I don't get what I expected.

@cristianbote
Copy link
Owner

Oh, you are correct! 🎉 If I move between categories I can reproduce it. Thank you! I'll get to it right away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants