Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not sign a psbt if specter does nit own any input #263

Open
pythcoiner opened this issue Nov 24, 2023 · 1 comment
Open

Do not sign a psbt if specter does nit own any input #263

pythcoiner opened this issue Nov 24, 2023 · 1 comment

Comments

@pythcoiner
Copy link
Contributor

I experienced this during Liana wallet testing (see here), specter will sign a PSBT even if no input is owned (in my case I load the wrong key).
Is there some reason to let sign such PSBT?
Shouldn't specter at least warn the user he's going to sign this king PSBT?

@stepansnigirev
Copy link
Collaborator

Specter-DIY actually counts number of signatures that it is adding to the transaction. If 0 signatures are added it will show an error screen with the text like "We didn't add any signatures".

It's very strange that it was able to sign the transaction without any warnings if the key is not in the setup. Would be nice to have a test vector to reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants