-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Array#insert_all
#14486
Merged
straight-shoota
merged 6 commits into
crystal-lang:master
from
summer-alice:feat/array-insert-all
Jun 11, 2024
Merged
Add Array#insert_all
#14486
straight-shoota
merged 6 commits into
crystal-lang:master
from
summer-alice:feat/array-insert-all
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method inserts all elements from a specified Enumerable or Iterable in to the Array at a specified index, moving any subsequent elements to the right.
The implementations of #insert_elements_at are almost the same, with the addition of an 'index' parameter, which for #concat is always the size of the array.
straight-shoota
requested changes
Apr 15, 2024
Co-authored-by: Johannes Müller <straightshoota@gmail.com>
straight-shoota
approved these changes
Apr 17, 2024
ysbaddaden
approved these changes
Jun 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a method to
Array
that allows you to insert all elements from one array into another at a given index.While this is already possible in Crystal using range assignment, the syntax and side effects may not be immediately obvious. Achieving the desired behaviour can also be error-prone as it depends on the number of dots used.
The new method would simplify it to:
(For further reference I did create a post on the forum)