Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attendance endpoint inconsistencies #366

Open
smartspot2 opened this issue Jan 10, 2023 · 0 comments
Open

Attendance endpoint inconsistencies #366

smartspot2 opened this issue Jan 10, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@smartspot2
Copy link
Member

The endpoint for mentors to get attendances is /api/sections/*/attendance/, but the endpoint for students to get attendances is /api/students/*/attendances/. In particular, the endpoint for mentors is singular, while the endpoint for students is plural.

It would make more sense if both endpoints were singular or both endpoints were plural; personally, plural makes a little more sense, since we're always getting all of the attendances (i.e. all attendances associated with the section, or all attendances associated with the student). Open to arguments for swapping to singular though.

@smartspot2 smartspot2 added enhancement New feature or request good first issue Good for newcomers labels Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant