Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email Case Sensitivity #385

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Email Case Sensitivity #385

wants to merge 2 commits into from

Conversation

edwardneo
Copy link
Contributor

@edwardneo edwardneo commented Feb 3, 2023 •
edited

Added lowercase email field to override Django's case sensitive email field (with tests).

@edwardneo edwardneo linked an issue Feb 3, 2023 that may be closed by this pull request
Email case sensitivity #378
Open
@cypress
Copy link

cypress bot commented Feb 3, 2023 •
edited

Passing run #77 ↗︎

0 78 0 0 Flakiness 0

Details:

Email Case Sensitivity
Project: csm_web Commit: d5e7d0bf8e
Status: Passed Duration: 02:36 💡
Started: Feb 10, 2023 1:47 AM Ended: Feb 10, 2023 1:50 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@edwardneo edwardneo marked this pull request as ready for review February 10, 2023 03:38
smartspot2
smartspot2 requested changes Feb 10, 2023
View reviewed changes
Copy link
Member

@smartspot2 smartspot2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but there's still a persistent issue where:

  1. Student already exists in the database, with a particular email
  2. Coordinator adds a student to a section by email, but this email has different case compared to the email of the user in the database
  3. Now there's two different users with the same (case-insensitive) email.

@smartspot2 smartspot2 added bug Something isn't working python Pull requests that update Python code sev4 Normal severity - System impaired labels Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smartspot2 smartspot2 smartspot2 requested changes

@ericyche ericyche Awaiting requested review from ericyche

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working python Pull requests that update Python code sev4 Normal severity - System impaired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Email case sensitivity
2 participants
@edwardneo @smartspot2