Skip to content
This repository has been archived by the owner on May 21, 2019. It is now read-only.

cuke4duke-maven-plugin is does not use username/password for proxy connection #112

Open
imod opened this issue Jun 11, 2011 · 2 comments
Open

Comments

@imod
Copy link

imod commented Jun 11, 2011

If maven is configured to use a proxy, the cuke4duke maven plugin only uses protocol/host/port combination while triggering the gem installation.
The plugin should add the username/password to the http-proxy argument too - otherwise the conenction to the outherworld fails!

e.g. if username/password is defined, it should not define the http-proxy like this:
--http-proxy http://myproxy.com:8080
but like this:
--http-proxy http://theuser:secret@myproxy.com:8080

@imod
Copy link
Author

imod commented Jun 11, 2011

I send a pull request to fix this issue: #113

@imod imod closed this as completed Jun 11, 2011
@imod imod reopened this Jun 11, 2011
@joelbyrnes
Copy link

This is also an issue for my team. We'd appreciate the fix being pulled in. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants