Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up output matchers #545

Open
mvz opened this issue Mar 4, 2018 · 2 comments
Open

Clean up output matchers #545

mvz opened this issue Mar 4, 2018 · 2 comments
Labels
Milestone

Comments

@mvz
Copy link
Contributor

mvz commented Mar 4, 2018

Summary

There are several matchers defined by Aruba that are very similar to matchers provided by RSpec. For example:

  • include_output_string and its aliases an_output_string_including and file_content_including. These seem similar to the include or perhaps match matchers.
  • include_an_object. This seems similar to include.

Expected Behavior

Aruba should use default RSpec matchers where possible to make its internal code comprehensible and to provide good examples for its users. Also, Aruba should not define generic matchers that may have to be supported beyond their internal use.

Current Behavior

There's a proliferation of matchers that increase the maintenance burden.

Possible Solution

Remove matchers that don't pull their weight.

Context & Motivation

Improving the output of failing steps is hard because there are many custom matchers that all need to be checked.

@mvz mvz added the internal label Mar 4, 2018
@stale
Copy link

stale bot commented May 3, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label May 3, 2018
@xtrasimplicity
Copy link
Member

Bumped.

@stale stale bot removed the stale These issues were closed by stalebot and need to be reviewed to see if they're still relevant. label May 3, 2018
@mvz mvz added this to the 1.1.0 milestone Jun 16, 2019
@mvz mvz modified the milestones: 1.1.0, 1.2.0 Aug 21, 2020
@mvz mvz modified the milestones: 1.2.0, 2.0.0 Jun 20, 2021
@mvz mvz modified the milestones: 2.0.0, 2.1.0 Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants