Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined announcer outputs binaries to stdout #667

Open
mvz opened this issue Aug 13, 2019 · 0 comments
Open

Combined announcer outputs binaries to stdout #667

mvz opened this issue Aug 13, 2019 · 0 comments

Comments

@mvz
Copy link
Contributor

mvz commented Aug 13, 2019

Summary

When activating the blanket announcer with @announce, the command_content announcer announces the full binary file if the command happens to be a binary file. This is bad and shouldn't happen.

Expected Behavior

When annotating a scenario with @announce, announced output should be useful for the developer.

Current Behavior

When annotating a scenario with @announce, all announcers are activated. The command_content announcer is one of them. If the command is a binary (e.g., ruby), the full binary is output, filling the terminal with a large amount of garbage.

Possible Solutions

  1. Have the command_content not output binaries.
  2. Do not include command_content in the announcers activated by @announce.

I think 1. is the best option, since it also removes the need for warnings about binaries in the documentation about the command_content announcer.

Steps to Reproduce (for bugs)

  1. Create a scenario annotated with @announce
  2. Have the scenario run ruby --version
  3. Run the scenario

Context & Motivation

This came up while examining #563, as mentioned in #649 (comment).

Your Environment

  • Version used: master, maybe also still
  • Operating System and version: Linux
@mvz mvz added this to the 1.1.0 milestone Aug 22, 2020
@mvz mvz modified the milestones: 1.1.0, 2.0.0 Jun 20, 2021
@mvz mvz modified the milestones: 2.0.0, 2.1.0 Aug 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant